Skip to content

Commit

Permalink
Merge pull request IdentityModel#1258 from m-mohr/patch-1
Browse files Browse the repository at this point in the history
Fix IdentityModel#1256: AuthCode w/ PKCE not supported for popups
  • Loading branch information
brockallen authored Jan 30, 2021
2 parents d5f5789 + 047f9b9 commit 2be23d0
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/UserManager.js
Original file line number Diff line number Diff line change
Expand Up @@ -424,7 +424,9 @@ export class UserManager extends OidcClient {
}
_signinCallback(url, navigator) {
Log.debug("UserManager._signinCallback");
return navigator.callback(url);
let useQuery = this._settings.response_mode === "query" || (!this._settings.response_mode && SigninRequest.isCode(this._settings.response_type));
let delimiter = useQuery ? "?" : "#";
return navigator.callback(url, undefined, delimiter);
}

signoutRedirect(args = {}) {
Expand Down

0 comments on commit 2be23d0

Please sign in to comment.