Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync/db: add just, hyperfine, k9s, and procs #147

Merged
merged 1 commit into from
Oct 21, 2022

Conversation

hdhoang
Copy link
Contributor

@hdhoang hdhoang commented Oct 18, 2022

Parts of #85

i found that procs zip file is not easy to support yet, so i opened a PR there and we will wait for their next release.

Additional tasks

  • Updated CHANGELOG.md

hope this helps!

@hdhoang hdhoang requested a review from chshersh as a code owner October 18, 2022 01:41
@chshersh chshersh added the hacktoberfest-accepted https://hacktoberfest.com/participation/ label Oct 18, 2022
@hdhoang
Copy link
Contributor Author

hdhoang commented Oct 18, 2022

i'm gonna fix default & adopt new procs version too!

Copy link
Owner

@chshersh chshersh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update so far!

Yes, the list of defaults needs to be updated. README has info about this:

@chshersh chshersh added enhancement New feature or request config TOML configuration, config-related CLI options tools-support Supporting more tools labels Oct 19, 2022
@hdhoang hdhoang changed the title sync/db: add just, hyperfine, and procs(without windows) sync/db: add just, hyperfine, k9s, and procs Oct 19, 2022
@hdhoang hdhoang requested a review from chshersh October 19, 2022 14:14
@chshersh
Copy link
Owner

@hdhoang Let's also patch the test suite for syncing all tools to make sure they indeed work. Relevant parts:

  • https://github.com/chshersh/tool-sync/blob/main/tests/sync-full.toml
  • - if: matrix.os != 'windows-latest'
    name: "Integration test: [unix] [sync-full]"
    env:
    SYNC_DIR: "sync-full"
    GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
    run: |
    mkdir $SYNC_DIR
    cargo run -- --config=tests/$SYNC_DIR.toml sync
    ls -l $SYNC_DIR
    if [[ ! -x $SYNC_DIR/bat ]]; then echo "error on: bat"; false; fi
    if [[ ! -x $SYNC_DIR/difft ]]; then echo "error on: difft"; false; fi
    if [[ ! -x $SYNC_DIR/exa ]]; then echo "error on: exa"; false; fi
    if [[ ! -x $SYNC_DIR/fd ]]; then echo "error on: fd"; false; fi
    if [[ ! -x $SYNC_DIR/rg ]]; then echo "error on: rg"; false; fi
    if [[ ! -x $SYNC_DIR/tool ]]; then echo "error on: tool"; false; fi
    if [[ ! -x $SYNC_DIR/gh ]]; then echo "error on: gh"; false; fi
    # disabled because of: https://github.com/alexcrichton/tar-rs/issues/295
    # if [[ ! -x $SYNC_DIR/tokei ]]; then echo "error on: tokei"; false; fi
  • - if: matrix.os == 'windows-latest'
    name: "Integration test: [windows] [full-database]"
    env:
    SYNC_DIR: "sync-full"
    GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
    run: |
    mkdir $env:SYNC_DIR
    cargo run -- --config="tests\$env:SYNC_DIR.toml" sync
    ls -l $env:SYNC_DIR
    if (!(Test-Path $env:SYNC_DIR\bat.exe)) {
    throw 'error on bat.exe'
    }
    if (!(Test-Path $env:SYNC_DIR\difft.exe)) {
    throw 'error on difft.exe'
    }
    if (!(Test-Path $env:SYNC_DIR\fd.exe)) {
    throw 'error on fd.exe'
    }
    if (!(Test-Path $env:SYNC_DIR\rg.exe)) {
    throw 'error on rg.exe'
    }
    if (!(Test-Path $env:SYNC_DIR\tool.exe)) {
    throw 'error on tool.exe'
    }
    if (!(Test-Path $env:SYNC_DIR\gh.exe)) {
    throw 'error on gh.exe'
    }

@hdhoang
Copy link
Contributor Author

hdhoang commented Oct 20, 2022

i have updated full CI, thanks!

Copy link
Owner

@chshersh chshersh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! 🏆

@chshersh chshersh merged commit f9b71cf into chshersh:main Oct 21, 2022
@hdhoang hdhoang deleted the db-just branch October 21, 2022 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config TOML configuration, config-related CLI options enhancement New feature or request hacktoberfest-accepted https://hacktoberfest.com/participation/ tools-support Supporting more tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants