Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add server flag documentation to watch peers #1229

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

kaworu
Copy link
Member

@kaworu kaworu commented Sep 28, 2023

Before this patch, hubble watch peers --help would not show the server related flags (e.g. --server).

I took a quick look and both list nodes and list namespaces have the server flags setup, so watch peers is the only sub-command to miss them.

Before this patch, `hubble watch peers --help` would not show the server
related flags (e.g. --server).

Signed-off-by: Alexandre Perrin <[email protected]>
@kaworu kaworu added 📄 area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. kind/enhancement This would improve or streamline existing functionality. release-note/misc This PR makes changes that have no direct user impact. labels Sep 28, 2023
@kaworu kaworu self-assigned this Sep 28, 2023
@kaworu kaworu requested a review from a team as a code owner September 28, 2023 12:50
@kaworu kaworu requested review from chancez and removed request for a team September 28, 2023 12:50
Copy link
Member

@rolinh rolinh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Sep 28, 2023
@kaworu kaworu merged commit 310aee6 into main Sep 29, 2023
@kaworu kaworu deleted the pr/kaworu/add-server-flags-help-to-watch-peers branch September 29, 2023 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📄 area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. kind/enhancement This would improve or streamline existing functionality. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants