Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example for MS SQL Server #6156

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

jbauerrfid
Copy link

Description

Add example for MS SQL Server

Reasons

Running MS SQL Server is a bit tricky in CircleCI. I want to share the build script worked out to save time for other devs.
Doing tests with MS SQL Server appears to be a common tasks, and I did not find anything functional in the CircleCI documentation.

Add Example project with Java and Microsoft SQL Server
@jbauerrfid jbauerrfid requested a review from a team January 8, 2022 10:45
@devinmarieb devinmarieb added the external open source contributor label Jan 10, 2022
@devinmarieb
Copy link
Contributor

Hi @jbauerrfid, thanks for taking the time to make this example project, but we unfortunately cannot include examples in our docs that rely on community orbs like cobli/[email protected] since we have no control over the maintenance or security of them.

Replace wait-for orb with shell command to avoid third party code in example.
@jbauerrfid
Copy link
Author

Hi @devinmarieb
I have updated the PR and replaced the ORB reference.
I would also propose to update your https://github.com/circleci/circleci-docs/blob/master/docs/CONTRIBUTING.md and add clarification about third party code like ORBs.

@devinmarieb
Copy link
Contributor

@jbauerrfid Thanks! Sorry for the delay. We've actually been having larger conversations around the best way to include projects like the one you originally proposed, where we can't include them in the official docs, but maybe we can have a new section for projects that use third party stuff. I appreciate the effort! We haven't forgotten about this :)

@jbauerrfid
Copy link
Author

Hi @devinmarieb

CircleCI is pretty quick at responding to contributions. I have open request on other OSS projects, where I wait for months or get no response from the maintainers at all.

So when you want to reorganize third party contributions it is ok for me.

@devinmarieb
Copy link
Contributor

@jbauerrfid Thanks! I'm going to keep this PR open until we make a final decision on what to do with projects that use third party tools. These example projects people suggest are very useful for others in similar situations, but we just don't have a good way of including them in our current structure. It's possible you will see it merged or a request for changes in a few months time :) Thanks for your suggestions!

@jbauerrfid
Copy link
Author

Hi @devinmarieb
did you see that I replaced the ORB code in my PR?

@devinmarieb
Copy link
Contributor

@jbauerrfid yes I did :) There's actually further internal discussion on this whole page in general now which is why I haven't merged yet.

@FelicianoTech
Copy link
Contributor

We need to re-review this. @circleci/dre

@rosieyohannan rosieyohannan requested review from a team as code owners December 11, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external open source contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants