Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

smoke_test: Fix Failure on Windows GitHub Workflow #571

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rlxdev
Copy link
Collaborator

@rlxdev rlxdev commented Jan 16, 2025

🗣 Description

Fixed the smoke test for the Windows workflow by correcting the use of the Python virtual environments for both OS flows. GitHub uses 2 drives in its VM/container when running a workflow on Windows, and it looks like OPA isn't handling it correctly when the current working directory is on one drive and is being passed input files on another drive. Regardless, we should be using the Python virtual environment correctly, and this fix takes care of the OPA issue as well (because OPA is run with the current working directory on the same drive as the input data).

The default OPA version used in the smoke test has been updated to v1.0.0. We really should be running the latest version of OPA for this test so we can catch any OPA issues before ScubaGoggles users encounter them.

Closes #529

🧪 Testing

Ran the smoke test workflow with both macOS and Windows runners and the tests complete successfully.

✅ Pre-approval checklist

  • This PR has an informative and human-readable title.
  • Changes are limited to a single goal - eschew scope creep!
  • If applicable, All future TODOs are captured in issues, which are referenced in the PR description.
  • The relevant issues PR resolves are linked preferably via closing keywords.
  • All relevant type-of-change labels have been added.
  • I have read and agree to the CONTRIBUTING.md document.
  • These code changes follow cisagov code standards.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
  • Tests have been added and/or modified to cover the changes in this PR.
  • All new and existing tests pass.

✅ Pre-merge Checklist

  • This PR has been smoke tested to ensure main is in a functional state when this PR is merged.
  • Squash all commits into one PR level commit using the Squash and merge button.

✅ Post-merge Checklist

  • Delete the branch to clean up.
  • Close issues resolved by this PR if the closing keywords did not activate.

@rlxdev rlxdev added the bug This issue or pull request addresses broken functionality label Jan 16, 2025
@rlxdev rlxdev linked an issue Jan 16, 2025 that may be closed by this pull request
@rlxdev rlxdev force-pushed the 529-fix-smoke-test branch from 3d799fe to dd1d14e Compare January 16, 2025 18:49
@rlxdev rlxdev force-pushed the 529-fix-smoke-test branch from dd1d14e to 40f8602 Compare January 16, 2025 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue or pull request addresses broken functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Windows Smoke Test
1 participant