Add support for multiple languages #84
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…CargoRoutingDTO to CargoAdminViewAdapter
… multiple locales
…ller onSubmit method
orende
force-pushed
the
finish-internationalization-work
branch
from
4ffe581 to
b171f21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A while ago I noticed a half-finished effort at adding internationalization to the project in the form of a partial
messages_en.propertiesfile. I decided to finish the work by externalizing all hardcoded strings from the html files into themessages_en.propertiesfile as well as adding translations for Swedish and simplified Chinese. I also rewrote parts of the code in theinterfacespackage where strings had been hardcoded and replaced them with externalized strings. Finally, I wrote aLocaleContextResolverto handle the mapping of the "lang" query parameter value to matching message sources.One feature I've left out for now is programmatic detection of new locales based on property file names, but that could be relatively easily added in the future.