This repository has been archived by the owner on Apr 7, 2023. It is now read-only.
fix(chat): Make sure user doesn't land on hidden or null chat mode, after using "chat:removeMode" #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR started from issue: https://forum.cfx.re/t/chat-chat-removemode-event-will-not-remove-the-all-mode-immediately/4790531/2
Changes made:
moved globalMode (_global) as the first mode, and defaultMode as second mode and changed default
modeIdxvalue to reflect that. This should fix the situations where users on default mode will have their "all" chat removed, but then could see "_global" chat.Added a check on
ON_MODE_REMOVE(), to make sure thatmodeIdxdoesn't point to anundefinedmode after removing the chat mode. (But it could still point to hidden modes!! )