Add iscsi/params test (#827) #230
Conversation
|
Hi! This is the friendly CKI test bot. The maintainers can mention me in a comment together with the word "test" and I will test this PR and post the results! |
|
Test result for x86 looks good, please refer to bkr job |
There was a problem hiding this comment.
I see messages like
FAIL:(libsan.host.mp) Could not execute "multipath -ll"
WARN: vda: Presuming virtual disk does not have wwid.
Unit multipathd.service could not be found.
INFO: Service multipathd could not be found.
in the linked job's taskout file, can you take a look on what causes them? The test did pass but errors like this can be confusing.
storage/include/libstqe.sh
Outdated
| pushd "." && rlRun "cd $fwroot" | ||
|
|
||
| [[ -n $STQE_STABLE_VERSION ]] && \ | ||
| rlRun "git checkout $STQE_STABLE_VERSION" || return 1 |
There was a problem hiding this comment.
Can we have the setup failures here and below abort the test? We don't want to report failures to developers because the repo couldn't be cloned, for example.
There was a problem hiding this comment.
Hi @veruu, for the test log having a failure, I'll mail to the test maintainer and copy to you soon.
For the setup failures, I updated storage/iscsi/params/runtest.sh and let it go to rlSkip(). Two beaker jobs are done, one (3614622) is for testing the latest test code, the other (3614634) is for testing it does go to rlSkip() by injecting return 2 to function stqe_init_fwroot(). Please take a look again, thanks!
There was a problem hiding this comment.
Thanks for the changes and looking into the issues! However I don't think the skipping is right to do here - we usually skip tests when the HW is not supported by a test and no one looks twice on it. But if eg. the git clone fails it may mean the repo was removed and we need to fix it. Aborted jobs grab people's attention as they clearly mark something is wrong.
There was a problem hiding this comment.
Hi @veruu, the test code is updated according to your comments. And I tested it via beaker.
- Abort:
3617291 - Pass:
3617293
BTW, Filip helped to fix FAIL:(libsan.host.mp) ... failure, now the test log looks fine.
There was a problem hiding this comment.
Looking good now, thanks @idorax and Filip for fixing the issues!
Signed-off-by: Vector Li <[email protected]>
iscsi/paramstest case is for testing targetcli by leveraginghttps://gitlab.com/rh-kernel-stqe/python-stqe, please help to review, thanks!