Updated get service requests by workflow name API #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tejash-jl
commented
Nov 11, 2020
tejash-jl
commented
- updated API to support sortBy query
- updated API to send total service requests count in response.
|
Do we have a linter set up? |
Yes, currently using it locally. Need to run it during the build as well. Created #83 to integrate the GoLint to build |
lohith46
reviewed
Dec 3, 2020
| @@ -56,7 +56,7 @@ func verifySortValues(key string, value string) bool { | |||
| if value != "desc" && value != "asc" { | |||
| return false | |||
| } | |||
| supportedKeys := []string{"id", "name", "created_at"} | |||
| supportedKeys := []string{"id", "name", "created_at", "workflow_name", "status"} | |||
There was a problem hiding this comment.
@tejash-jl We can externalize sort fields to some constants file or env file ??
priyaaank
approved these changes
Mar 11, 2021
|
Sorry, @tejash-jl I took a bit of time to review it. Can you please resolve conflicts? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.