Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clar: define feature macros in "clar.c" #106

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

pks-t
Copy link
Member

@pks-t pks-t commented Oct 11, 2024

Compiling clar requires several different extensions which are not part
of ISO C90, like strdup(3P), lstat(3P) and mkdtemp(3P). And while we
define these via our CMake build instructions, downstream users do not
benefit from this and will have to make sure that they set these.

Let's instead pull the definitions into "clar.c" such that the macros
are defined for everyone.

@pks-t pks-t force-pushed the pks-opensuse-compatibility branch 3 times, most recently from 7b1698c to e132523 Compare October 11, 2024 08:11
Compiling clar requires several different extensions which are not part
of ISO C90, like strdup(3P), lstat(3P) and mkdtemp(3P). And while we
define these via our CMake build instructions, downstream users do not
benefit from this and will have to make sure that they set these.

Let's instead pull the definitions into "clar.c" such that the macros
are defined for everyone.
@pks-t pks-t force-pushed the pks-opensuse-compatibility branch from e773d8d to 4f746f4 Compare October 11, 2024 08:40
@pks-t pks-t changed the title WIP: Compatibility with OpenSUSE Define feature test macros in "clar.c" Oct 11, 2024
@pks-t pks-t changed the title Define feature test macros in "clar.c" clar: define feature macros in "clar.c" Oct 11, 2024
@pks-t pks-t self-assigned this Oct 11, 2024
@pks-t pks-t requested a review from ethomson October 11, 2024 08:49
@Tux
Copy link

Tux commented Oct 11, 2024

✔ Thanks. (/me checked and approves)

@ethomson ethomson merged commit 6925d1d into clar-test:main Oct 11, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants