Fix build on systems with new versions of protobuf library #7372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patch from clementine-player#7272
FindProtobuf provided by CMake forgets that it should depend on libabsl, and link fails. This change makes it to use files provided by Protobuf library, which don't miss that important detail. That also required switch from protobuf_generate_cpp() to protobuf_generate() because that's the function which it has. FindProtobuf.cmake also provides protobuf_generate() but only since CMake 3.13. Fix clementine-player#7272
This is for older protobuf library
FindProtobuf.cmake's protobuf_generate() requires 3.13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.