Change color of h3 elements #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The red color used by the h3 elements was hard to read when applied to Officer's names. It should probably be used more for emphasis. I exchanged the color for the light violet color which I believe is much easier on the eyes.
|
Can you share some comparison shots? I don't have a development setup yet, so I really can't give any input on coloring. |
New Colors
Old Colors
|
|
Looks good for now. Like I said in #3, I still want to change the colors up a bit before I push it to http://cs.clemson.edu/acm/, but I'll merge it. |
lilyinstarlight
added a commit
that referenced
this pull request
Sep 18, 2015
make h3 elements light violet instead of red
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The red color used by the h3 elements was hard to read when applied to
Officer's names. It should probably be used more for emphasis. I
exchanged the color for the light violet color which I believe is much
easier on the eyes.