Fixed StateConfiguration.groupByIdAndRemoveRedundantHandlers to not l…

…ist handlers with guards after handlers without guards.
clnhlzmn · Apr 5, 2021 · bfbb885 · bfbb885
1 parent d45e540
commit bfbb885
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 3 deletions.
diff --git a/makina-compiler/out/artifacts/makina_compiler_jar/makina-compiler.jar b/makina-compiler/out/artifacts/makina_compiler_jar/makina-compiler.jar
diff --git a/makina-compiler/src/xyz/colinholzman/makina/StateConfiguration.kt b/makina-compiler/src/xyz/colinholzman/makina/StateConfiguration.kt
@@ -42,7 +42,7 @@ data class StateConfiguration(val states: Set<State>) {
         fun List<Pair<State, Handler.Event>>.groupByIdAndRemoveRedundantHandlers(): Map<String, List<Pair<State, Handler.Event>>> {
             return groupBy { it.second.id }.mapValues { entry ->
                 val guards = HashSet<String?>()
-                entry.value.filter { guards.add(it.second.guard) }
+                entry.value.filter { !guards.contains(null) && guards.add(it.second.guard) }
             }
         }
     }

diff --git a/makina-compiler/test/xyz/colinholzman/makina/StateConfigurationTest.kt b/makina-compiler/test/xyz/colinholzman/makina/StateConfigurationTest.kt
@@ -70,8 +70,7 @@ internal class StateConfigurationTest {
                 Pair(s11, Handler.Event("foo")),
                 Pair(s1, Handler.Event("foo", guard = "bar"))
         )
-        expected = mapOf(Pair("foo", listOf(Pair(s111, Handler.Event("foo")),
-                                            Pair(s1, Handler.Event("foo", guard = "bar")))))
+        expected = mapOf(Pair("foo", listOf(Pair(s111, Handler.Event("foo")))))
         assertEquals(expected, handlers.groupByIdAndRemoveRedundantHandlers())