Adds Fullstack Nextjs Auth Tutorial #18092
Conversation
|
Please let me know if any changes need to be made. Thanks! |
![hyperlint-ai[bot]](https://avatars.githubusercontent.com/in/718456?s=60&v=4){kind=small}
There was a problem hiding this comment.
2 files reviewed, 3 total issue(s) found.
Note: We resolved prior Hyperlint review comments because:
We updated our inline suggestion AI.
We do this to avoid keeping outdated or irrelevant comments around. We'll leave a new review with current comments below.
...cs/developer-spotlight/tutorials/fullstack-authentication-with-next-js-and-cloudflare-d1.mdx
Outdated
Show resolved
Hide resolved
...cs/developer-spotlight/tutorials/fullstack-authentication-with-next-js-and-cloudflare-d1.mdx
Outdated
Show resolved
Hide resolved
...cs/developer-spotlight/tutorials/fullstack-authentication-with-next-js-and-cloudflare-d1.mdx
Outdated
Show resolved
Hide resolved
db-cloudflare
added
DevRel
There was a problem hiding this comment.
Hey @mackenly, thank you for this great tutorial! I have reviewed it and left a few comments. At it's current state, I was not able to run it successfully. The reason being the table not getting created at all. In the comments, you will find more details.
...cs/developer-spotlight/tutorials/fullstack-authentication-with-next-js-and-cloudflare-d1.mdx
Outdated
Show resolved
Hide resolved
...cs/developer-spotlight/tutorials/fullstack-authentication-with-next-js-and-cloudflare-d1.mdx
Outdated
Show resolved
Hide resolved
...cs/developer-spotlight/tutorials/fullstack-authentication-with-next-js-and-cloudflare-d1.mdx
Outdated
Show resolved
Hide resolved
...cs/developer-spotlight/tutorials/fullstack-authentication-with-next-js-and-cloudflare-d1.mdx
Show resolved
Hide resolved
...cs/developer-spotlight/tutorials/fullstack-authentication-with-next-js-and-cloudflare-d1.mdx
Outdated
Show resolved
Hide resolved
...cs/developer-spotlight/tutorials/fullstack-authentication-with-next-js-and-cloudflare-d1.mdx
Show resolved
Hide resolved
...cs/developer-spotlight/tutorials/fullstack-authentication-with-next-js-and-cloudflare-d1.mdx
Outdated
Show resolved
Hide resolved
...cs/developer-spotlight/tutorials/fullstack-authentication-with-next-js-and-cloudflare-d1.mdx
Show resolved
Hide resolved
...cs/developer-spotlight/tutorials/fullstack-authentication-with-next-js-and-cloudflare-d1.mdx
Show resolved
Hide resolved
...cs/developer-spotlight/tutorials/fullstack-authentication-with-next-js-and-cloudflare-d1.mdx
Outdated
Show resolved
Hide resolved
|
@harshil1712 I'll take a look and address feedback items. Thanks! |
...cs/developer-spotlight/tutorials/fullstack-authentication-with-next-js-and-cloudflare-d1.mdx
Outdated
Show resolved
Hide resolved
…gnostic component
|
Hey @mackenly, please let me know if it is ready for review |
|
@harshil1712 A few outstanding feedback follow-up questions. If you can, take a look at these, and let me know next steps:
|
|
Hey @mackenly, |
|
The latest version of OpenNext seems to have a bug with Authjs' middleware. If that's something that can be fixed great, if not, the middleware is optional, so I guess we can leave that out until the bug is resolved. |
|
Hey @mackenly, great work. Is there anything else you would like to change before your PR is approved by @harshil1712? |
|
@db-cloudflare and @harshil1712, this should be good for your review now. The opennext middleware bug has been fixed. |
Summary
Developer Spotlight Tutorial
Contact with Daniel Benhamou
Documentation checklist