Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds Fullstack Nextjs Auth Tutorial #18092

Merged
merged 12 commits into from
Jan 27, 2025
Merged

Adds Fullstack Nextjs Auth Tutorial #18092

merged 12 commits into from
Jan 27, 2025

Conversation

mackenly
Copy link
Contributor

Summary

Developer Spotlight Tutorial
Contact with Daniel Benhamou

Documentation checklist

  • The documentation style guide has been adhered to.
  • If a larger change - such as adding a new page- an issue has been opened in relation to any incorrect or out of date information that this PR fixes.

@mackenly mackenly requested a review from a team as a code owner November 11, 2024 03:13
@mackenly
Copy link
Contributor Author

Please let me know if any changes need to be made. Thanks!

hyperlint-ai[bot]
hyperlint-ai bot reviewed Nov 11, 2024
View reviewed changes
Copy link
Contributor

@hyperlint-ai hyperlint-ai bot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, 3 total issue(s) found.

Note: We resolved prior Hyperlint review comments because:

We updated our inline suggestion AI.

We do this to avoid keeping outdated or irrelevant comments around. We'll leave a new review with current comments below.

...cs/developer-spotlight/tutorials/fullstack-authentication-with-next-js-and-cloudflare-d1.mdx Outdated Show resolved Hide resolved
...cs/developer-spotlight/tutorials/fullstack-authentication-with-next-js-and-cloudflare-d1.mdx Outdated Show resolved Hide resolved
...cs/developer-spotlight/tutorials/fullstack-authentication-with-next-js-and-cloudflare-d1.mdx Outdated Show resolved Hide resolved
@db-cloudflare db-cloudflare added DevRel Tasks that need support from developer relations. developer-spotlight labels Nov 11, 2024
@harshil1712 harshil1712 self-assigned this Nov 14, 2024
harshil1712
harshil1712 reviewed Nov 27, 2024
View reviewed changes
Copy link
Contributor

@harshil1712 harshil1712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mackenly, thank you for this great tutorial! I have reviewed it and left a few comments. At it's current state, I was not able to run it successfully. The reason being the table not getting created at all. In the comments, you will find more details.

...cs/developer-spotlight/tutorials/fullstack-authentication-with-next-js-and-cloudflare-d1.mdx Outdated Show resolved Hide resolved
...cs/developer-spotlight/tutorials/fullstack-authentication-with-next-js-and-cloudflare-d1.mdx Outdated Show resolved Hide resolved
...cs/developer-spotlight/tutorials/fullstack-authentication-with-next-js-and-cloudflare-d1.mdx Outdated Show resolved Hide resolved
...cs/developer-spotlight/tutorials/fullstack-authentication-with-next-js-and-cloudflare-d1.mdx Show resolved Hide resolved
...cs/developer-spotlight/tutorials/fullstack-authentication-with-next-js-and-cloudflare-d1.mdx Outdated Show resolved Hide resolved
...cs/developer-spotlight/tutorials/fullstack-authentication-with-next-js-and-cloudflare-d1.mdx Show resolved Hide resolved
...cs/developer-spotlight/tutorials/fullstack-authentication-with-next-js-and-cloudflare-d1.mdx Outdated Show resolved Hide resolved
...cs/developer-spotlight/tutorials/fullstack-authentication-with-next-js-and-cloudflare-d1.mdx Show resolved Hide resolved
...cs/developer-spotlight/tutorials/fullstack-authentication-with-next-js-and-cloudflare-d1.mdx Show resolved Hide resolved
...cs/developer-spotlight/tutorials/fullstack-authentication-with-next-js-and-cloudflare-d1.mdx Outdated Show resolved Hide resolved
@mackenly
Copy link
Contributor Author

mackenly commented Dec 2, 2024

@harshil1712 I'll take a look and address feedback items. Thanks!

@harshil1712
Copy link
Contributor

Hey @mackenly, please let me know if it is ready for review

@mackenly
Copy link
Contributor Author

@harshil1712 A few outstanding feedback follow-up questions. If you can, take a look at these, and let me know next steps:

@harshil1712
Copy link
Contributor

Hey @mackenly,
Hope your holidays were fun!
Apologies for the delay on my end. I have addressed all the remaining comments. Please let me know if I missed any.

@mackenly
Copy link
Contributor Author

mackenly commented Jan 14, 2025 •
edited
Loading

The latest version of OpenNext seems to have a bug with Authjs' middleware. If that's something that can be fixed great, if not, the middleware is optional, so I guess we can leave that out until the bug is resolved.
See issue: opennextjs/opennextjs-cloudflare#252
This issue is resolved.

@db-cloudflare
Copy link
Contributor

Hey @mackenly, great work. Is there anything else you would like to change before your PR is approved by @harshil1712?

@mackenly
Copy link
Contributor Author

@db-cloudflare and @harshil1712, this should be good for your review now. The opennext middleware bug has been fixed.

harshil1712
harshil1712 approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@harshil1712 harshil1712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for working on this. Excited to see this go live!

@db-cloudflare db-cloudflare enabled auto-merge (squash) January 27, 2025 13:50
@db-cloudflare db-cloudflare merged commit 95bd37a into cloudflare:production Jan 27, 2025
6 checks passed
@workers-devprod workers-devprod added the contribution [Holopin] Recognizes a docs contribution, big or small label Jan 27, 2025
@holopin-bot Holopin Bot
Copy link

holopin-bot bot commented Jan 27, 2025

Congratulations @mackenly, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cm6f4tbcj06830cjuqqrtistn

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

deadlypants1973 pushed a commit that referenced this pull request Jan 29, 2025
@mackenly @deadlypants1973
Adds Fullstack Nextjs Auth Tutorial (#18092)
47b4ea0 
* Adds fullstack nextjs auth tutorial draft

* Style fixes

* Adds auth link and fixes create args

* Moves args to args object for shadcn install

* Refactor resend prereq

* Removes unneeded localhost flag

* Removes extra backticks

* Adds description to page code and swaps runs to use package manager agnostic component

* Fix env access to use cloudflare context

* Edits and fixes to resolve issues
kodster28 pushed a commit that referenced this pull request Jan 30, 2025
@mackenly @kodster28
Adds Fullstack Nextjs Auth Tutorial (#18092)
7bb183e 
* Adds fullstack nextjs auth tutorial draft

* Style fixes

* Adds auth link and fixes create args

* Moves args to args object for shadcn install

* Refactor resend prereq

* Removes unneeded localhost flag

* Removes extra backticks

* Adds description to page code and swaps runs to use package manager agnostic component

* Fix env access to use cloudflare context

* Edits and fixes to resolve issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyperlint-ai hyperlint-ai[bot] hyperlint-ai[bot] left review comments

@db-cloudflare db-cloudflare db-cloudflare approved these changes

@harshil1712 harshil1712 harshil1712 approved these changes

Assignees

@pedrosousa pedrosousa

@harshil1712 harshil1712

@dcpena dcpena

@haleycode haleycode

@patriciasantaana patriciasantaana

Labels
contribution [Holopin] Recognizes a docs contribution, big or small developer-spotlight DevRel Tasks that need support from developer relations. product:developer-spotlight size/m
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@mackenly @harshil1712 @db-cloudflare @pedrosousa @dcpena @haleycode @patriciasantaana @workers-devprod