Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SSL] Remove word Step from headings and adjust anchors #17460

Merged
merged 7 commits into from
Oct 14, 2024

Conversation

RebeccaTamachiro
Copy link
Contributor

Summary

PCX-7128

@RebeccaTamachiro RebeccaTamachiro requested a review from a team as a code owner October 10, 2024 13:28
@github-actions github-actions bot added product:ssl Related to SSL size/s labels Oct 10, 2024
Copy link
Contributor

@hyperlint-ai hyperlint-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8 files reviewed, 4 total issue(s) found.

@@ -126,7 +126,7 @@ Using "CKM_SHA256_RSA_PKCS" Mechanism

## 3. Obtain and upload a signed certificate from your Certificate Authority (CA)

Provide the CSR created in the previous step to your organizations preferred CA, demonstrate control of your domain as requested, and then download the signed SSL certificates. Follow the instructions provided in [Uploading “Keyless” SSL Certificates](/ssl/keyless-ssl/configuration/cloudflare-tunnel/#step-3---upload-keyless-ssl-certificates).
Provide the CSR created in the previous step to your organization's preferred CA, demonstrate control of your domain as requested, and then download the signed SSL certificates. Follow the instructions provided in [Uploading “Keyless” SSL Certificates](/ssl/keyless-ssl/configuration/cloudflare-tunnel/#3-upload-keyless-ssl-certificates).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Provide the CSR created in the previous step to your organization's preferred CA, demonstrate control of your domain as requested, and then download the signed SSL certificates. Follow the instructions provided in [Uploading Keyless SSL Certificates](/ssl/keyless-ssl/configuration/cloudflare-tunnel/#3-upload-keyless-ssl-certificates).
Provide the CSR created in the previous step to your organization's preferred CA, demonstrate control of your domain as requested, and then download the signed SSL certificates. Follow the instructions provided in [Uploading "Keyless" SSL Certificates](/ssl/keyless-ssl/configuration/cloudflare-tunnel/#3-upload-keyless-ssl-certificates).

Issues:

  • Style Guide - (cloudflare.NonStandardQuotes-warning) Use standard single quotes or double quotes only. Do not use left or right quotes.
  • Style Guide - (cloudflare.NonStandardQuotes-warning) Use standard single quotes or double quotes only. Do not use left or right quotes.

Fix Explanation:

The original text uses non-standard quotes around "Keyless". To comply with the style guide, I've replaced them with standard double quotes. This change ensures consistency and adherence to the style guide without altering the meaning of the text.

@@ -123,7 +123,7 @@ Using "CKM_ECDSA_SHA256" Mechanism

## 3. Obtain and upload signed certificates from your Certificate Authority (CA)

Provide the CSRs created in the previous step to your organization’s preferred CA, demonstrate control of your domain as requested, and then download the signed SSL certificates. Follow the instructions provided in [Uploading “Keyless” SSL Certificates](/ssl/keyless-ssl/configuration/cloudflare-tunnel/#step-3---upload-keyless-ssl-certificates).
Provide the CSRs created in the previous step to your organization’s preferred CA, demonstrate control of your domain as requested, and then download the signed SSL certificates. Follow the instructions provided in [Uploading “Keyless” SSL Certificates](/ssl/keyless-ssl/configuration/cloudflare-tunnel/#3-upload-keyless-ssl-certificates).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Provide the CSRs created in the previous step to your organization’s preferred CA, demonstrate control of your domain as requested, and then download the signed SSL certificates. Follow the instructions provided in [Uploading Keyless SSL Certificates](/ssl/keyless-ssl/configuration/cloudflare-tunnel/#3-upload-keyless-ssl-certificates).
Provide the CSRs created in the previous step to your organization’s preferred CA, demonstrate control of your domain as requested, and then download the signed SSL certificates. Follow the instructions provided in [Uploading "Keyless" SSL Certificates](/ssl/keyless-ssl/configuration/cloudflare-tunnel/#3-upload-keyless-ssl-certificates).

Issues:

  • Style Guide - (cloudflare.NonStandardQuotes-warning) Use standard single quotes or double quotes only. Do not use left or right quotes.
  • Style Guide - (cloudflare.NonStandardQuotes-warning) Use standard single quotes or double quotes only. Do not use left or right quotes.
  • Style Guide - (cloudflare.NonStandardQuotes-warning) Use standard single quotes or double quotes only. Do not use left or right quotes.

Fix Explanation:

The original text uses non-standard quotes around "Keyless" SSL Certificates. To comply with the style guide, I've replaced them with standard double quotes. This change ensures consistency and adherence to the documentation standards.

Copy link

cloudflare-workers-and-pages bot commented Oct 10, 2024

Deploying cloudflare-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1f84920
Status: ✅  Deploy successful!
Preview URL: https://11a28471.cloudflare-docs-7ou.pages.dev
Branch Preview URL: https://rebecca-chore-review-step-he.cloudflare-docs-7ou.pages.dev

View logs

Copy link

github-actions bot commented Oct 10, 2024

Files with changes (up to 15)

Original Link Updated Link
https://developers.cloudflare.com/ssl/client-certificates/configure-your-mobile-app-or-iot-device/ https://rebecca-chore-review-step-he.cloudflare-docs-7ou.pages.dev/ssl/client-certificates/configure-your-mobile-app-or-iot-device/
https://developers.cloudflare.com/cloudflare-for-platforms/cloudflare-for-saas/security/certificate-management/issue-and-validate/validate-certificates/txt/ https://rebecca-chore-review-step-he.cloudflare-docs-7ou.pages.dev/cloudflare-for-platforms/cloudflare-for-saas/security/certificate-management/issue-and-validate/validate-certificates/txt/
https://developers.cloudflare.com/cloudflare-for-platforms/cloudflare-for-saas/start/getting-started/ https://rebecca-chore-review-step-he.cloudflare-docs-7ou.pages.dev/cloudflare-for-platforms/cloudflare-for-saas/start/getting-started/
https://developers.cloudflare.com/cloudflare-for-platforms/cloudflare-for-saas/security/certificate-management/custom-certificates/certificate-signing-requests/ https://rebecca-chore-review-step-he.cloudflare-docs-7ou.pages.dev/cloudflare-for-platforms/cloudflare-for-saas/security/certificate-management/custom-certificates/certificate-signing-requests/
https://developers.cloudflare.com/cloudflare-for-platforms/cloudflare-for-saas/start/advanced-settings/apex-proxying/setup/ https://rebecca-chore-review-step-he.cloudflare-docs-7ou.pages.dev/cloudflare-for-platforms/cloudflare-for-saas/start/advanced-settings/apex-proxying/setup/
https://developers.cloudflare.com/ssl/edge-certificates/staging-environment/ https://rebecca-chore-review-step-he.cloudflare-docs-7ou.pages.dev/ssl/edge-certificates/staging-environment/
https://developers.cloudflare.com/ssl/keyless-ssl/configuration/cloudflare-tunnel/ https://rebecca-chore-review-step-he.cloudflare-docs-7ou.pages.dev/ssl/keyless-ssl/configuration/cloudflare-tunnel/
https://developers.cloudflare.com/cloudflare-for-platforms/cloudflare-for-saas/security/certificate-management/custom-certificates/uploading-certificates/ https://rebecca-chore-review-step-he.cloudflare-docs-7ou.pages.dev/cloudflare-for-platforms/cloudflare-for-saas/security/certificate-management/custom-certificates/uploading-certificates/
https://developers.cloudflare.com/cloudflare-for-platforms/cloudflare-for-saas/security/waf-for-saas/managed-rulesets/ https://rebecca-chore-review-step-he.cloudflare-docs-7ou.pages.dev/cloudflare-for-platforms/cloudflare-for-saas/security/waf-for-saas/managed-rulesets/
https://developers.cloudflare.com/ssl/edge-certificates/encrypt-visitor-traffic/ https://rebecca-chore-review-step-he.cloudflare-docs-7ou.pages.dev/ssl/edge-certificates/encrypt-visitor-traffic/
https://developers.cloudflare.com/ssl/keyless-ssl/configuration/public-dns/ https://rebecca-chore-review-step-he.cloudflare-docs-7ou.pages.dev/ssl/keyless-ssl/configuration/public-dns/
https://developers.cloudflare.com/cloudflare-for-platforms/cloudflare-for-saas/domain-support/hostname-validation/realtime-validation/ https://rebecca-chore-review-step-he.cloudflare-docs-7ou.pages.dev/cloudflare-for-platforms/cloudflare-for-saas/domain-support/hostname-validation/realtime-validation/
https://developers.cloudflare.com/cloudflare-for-platforms/cloudflare-for-saas/security/waf-for-saas/ https://rebecca-chore-review-step-he.cloudflare-docs-7ou.pages.dev/cloudflare-for-platforms/cloudflare-for-saas/security/waf-for-saas/
https://developers.cloudflare.com/reference-architecture/design-guides/extending-cloudflares-benefits-to-saas-providers-end-customers/ https://rebecca-chore-review-step-he.cloudflare-docs-7ou.pages.dev/reference-architecture/design-guides/extending-cloudflares-benefits-to-saas-providers-end-customers/
https://developers.cloudflare.com/cloudflare-for-platforms/cloudflare-for-saas/domain-support/hostname-validation/ https://rebecca-chore-review-step-he.cloudflare-docs-7ou.pages.dev/cloudflare-for-platforms/cloudflare-for-saas/domain-support/hostname-validation/

@RebeccaTamachiro RebeccaTamachiro merged commit 1520780 into production Oct 14, 2024
13 checks passed
@RebeccaTamachiro RebeccaTamachiro deleted the rebecca/chore-review-step-headings branch October 14, 2024 07:10
elithrar pushed a commit that referenced this pull request Oct 15, 2024
* First pass bulk find and replace

* Find anchor links and manually fix

* Fix Hyperlint flagged issue

* Fix Hyperlint flagged issue

* Find and replace in cloudflare-for-saas as well

* Search for and fix anchor links

* Fix more anchor links based on branch audit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants