Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Browser Rendering] Guide for PDF Rendering from HTML and CSS #17510

Merged
merged 3 commits into from
Oct 14, 2024

Conversation

hturan
Copy link
Contributor

@hturan hturan commented Oct 14, 2024

Summary

This PR adds a new how-to detailing how to render PDFs using Cloudflare Workers and Browser Rendering.

Screenshots (optional)

Screenshot 2024-10-14 at 12 45 05

Documentation checklist

Copy link
Contributor

@hyperlint-ai hyperlint-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, 13 total issue(s) found.

Copy link

cloudflare-workers-and-pages bot commented Oct 14, 2024

Deploying cloudflare-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: ee0c448
Status: ✅  Deploy successful!
Preview URL: https://61540305.cloudflare-docs-7ou.pages.dev
Branch Preview URL: https://hturan-browser-rendering-pdf.cloudflare-docs-7ou.pages.dev

View logs

Copy link
Contributor

@Oxyjun Oxyjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adjustments to conform to the Style Guide.

Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com>
Changing our -> your.
@hturan
Copy link
Contributor Author

hturan commented Oct 14, 2024

Thanks for the review and changes @Oxyjun! Will keep things in the second-person in the future :)

@Oxyjun
Copy link
Contributor

Oxyjun commented Oct 14, 2024

Thanks for the review and changes @Oxyjun! Will keep things in the second-person in the future :)

No worries at all! It was well written anyway - sorry if I came across as nit-picky, thought I'd just align it with other docs :D

@hturan hturan merged commit fa76a12 into production Oct 14, 2024
13 checks passed
@hturan hturan deleted the hturan/browser-rendering-pdf branch October 14, 2024 15:42
elithrar pushed a commit that referenced this pull request Oct 15, 2024
* Create guide for PDF rendering using workers

* Apply suggestions from code review part 1

Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com>

* Apply suggestions from code review

Changing our -> your.

---------

Co-authored-by: Jun Lee <[email protected]>
Co-authored-by: hyperlint-ai[bot] <154288675+hyperlint-ai[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants