[Workers] Added footnotes component & legend #17634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcpena
requested review from
irvinebroque,
tanushree-sharma,
GregBrimble,
WalshyDev and
a team
as code owners
Deploying cloudflare-docs with
|
| Latest commit: |
58b167d
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://948e70b3.cloudflare-docs-7ou.pages.dev |
| Branch Preview URL: | https://dpena-add-footnotes-legend.cloudflare-docs-7ou.pages.dev |
Oxyjun
approved these changes
Oct 18, 2024
Oxyjun
reviewed
Oct 18, 2024
| @@ -11,46 +11,53 @@ import { | |||
| Badge, | |||
| Description, | |||
| FileTree, | |||
| Footnotes, | |||
There was a problem hiding this comment.
Suggested change
| Footnotes, |
I just disappointed @KianNH for not catching this - footnotes is already built-in, so don't need to be called here.
There was a problem hiding this comment.
|
Files with changes (up to 15) |
GregBrimble
approved these changes
Oct 18, 2024
src/content/docs/workers/static-assets/compatibility-matrix.mdx
Outdated
Show resolved
Hide resolved
| @@ -11,46 +11,53 @@ import { | |||
| Badge, | |||
| Description, | |||
| FileTree, | |||
| Footnotes, | |||
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented footnotes component, added legend, and a few other suggestions from previous PR that weren't added before merge.