Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Review cloudflare_ruleset Terraform examples #18689

Conversation

pedrosousa
Copy link
Contributor

@pedrosousa pedrosousa commented Dec 11, 2024

Summary

Updates Terraform examples using the cloudflare_ruleset resource to match changes in cloudflare/terraform-provider-cloudflare#4752:

  • Adds a ref value to each rule, according to our recommendation.
  • Uses the same order for rule attributes: ref, description, expression, action.

Also updates a link to Terraform docs so that it's not tied to a specific version (and there are more recent versions now).

@github-actions github-actions bot added product:cache Issues or PRs related to Cache product:rules Related to rules product:terraform Related to Terraform product size/m labels Dec 11, 2024
Copy link

cloudflare-workers-and-pages bot commented Dec 11, 2024

Deploying cloudflare-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 29b2348
Status: ✅  Deploy successful!
Preview URL: https://0bf522c6.cloudflare-docs-7ou.pages.dev
Branch Preview URL: https://pedro-2024-12-11-docs-update.cloudflare-docs-7ou.pages.dev

View logs

Copy link

github-actions bot commented Dec 11, 2024

Files with changes (up to 15)

Original Link Updated Link
https://developers.cloudflare.com/terraform/additional-configurations/waf-managed-rulesets/ https://pedro-2024-12-11-docs-update.cloudflare-docs-7ou.pages.dev/terraform/additional-configurations/waf-managed-rulesets/
https://developers.cloudflare.com/terraform/additional-configurations/rate-limiting-rules/ https://pedro-2024-12-11-docs-update.cloudflare-docs-7ou.pages.dev/terraform/additional-configurations/rate-limiting-rules/
https://developers.cloudflare.com/terraform/additional-configurations/waf-custom-rules/ https://pedro-2024-12-11-docs-update.cloudflare-docs-7ou.pages.dev/terraform/additional-configurations/waf-custom-rules/
https://developers.cloudflare.com/terraform/additional-configurations/transform-rules/ https://pedro-2024-12-11-docs-update.cloudflare-docs-7ou.pages.dev/terraform/additional-configurations/transform-rules/
https://developers.cloudflare.com/terraform/additional-configurations/ddos-managed-rulesets/ https://pedro-2024-12-11-docs-update.cloudflare-docs-7ou.pages.dev/terraform/additional-configurations/ddos-managed-rulesets/
https://developers.cloudflare.com/speed/optimization/content/speed-brain/ https://pedro-2024-12-11-docs-update.cloudflare-docs-7ou.pages.dev/speed/optimization/content/speed-brain/
https://developers.cloudflare.com/cache/how-to/cache-rules/terraform-example/ https://pedro-2024-12-11-docs-update.cloudflare-docs-7ou.pages.dev/cache/how-to/cache-rules/terraform-example/
https://developers.cloudflare.com/rules/configuration-rules/examples/define-single-configuration-terraform/ https://pedro-2024-12-11-docs-update.cloudflare-docs-7ou.pages.dev/rules/configuration-rules/examples/define-single-configuration-terraform/
https://developers.cloudflare.com/rules/origin-rules/examples/define-single-origin-terraform/ https://pedro-2024-12-11-docs-update.cloudflare-docs-7ou.pages.dev/rules/origin-rules/examples/define-single-origin-terraform/
https://developers.cloudflare.com/rules/url-forwarding/single-redirects/terraform-example/ https://pedro-2024-12-11-docs-update.cloudflare-docs-7ou.pages.dev/rules/url-forwarding/single-redirects/terraform-example/

@pedrosousa pedrosousa marked this pull request as ready for review December 30, 2024 10:12
@pedrosousa pedrosousa requested review from angelampcosta, a team and ranbel as code owners December 30, 2024 10:12
@pedrosousa pedrosousa enabled auto-merge (squash) December 30, 2024 10:32
@pedrosousa pedrosousa merged commit 343548f into production Dec 30, 2024
12 checks passed
@pedrosousa pedrosousa deleted the pedro/2024-12-11-docs-update-terraform-examples-with-rulesets branch December 30, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product:cache Issues or PRs related to Cache product:rules Related to rules product:speed product:terraform Related to Terraform product size/m
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants