Replace update_all to update_column in CarrierWave storage

cloudinary · Nov 5, 2023 · b854b88 · b854b88
1 parent 07811e7
commit b854b88
Showing 1 changed file with 1 addition and 8 deletions.
diff --git a/lib/cloudinary/carrier_wave/storage.rb b/lib/cloudinary/carrier_wave/storage.rb
@@ -82,14 +82,7 @@ def store_cloudinary_identifier(version, filename, resource_type=nil, type=nil)
     end
 
     if defined?(ActiveRecord::Base) && uploader.model.is_a?(ActiveRecord::Base)
-      primary_key = model_class.primary_key.to_sym
-      if defined?(::ActiveRecord::VERSION::MAJOR) && ::ActiveRecord::VERSION::MAJOR > 2
-        model_class.where(primary_key=>uploader.model.send(primary_key)).update_all(column=>name)
-      else
-        # Removed since active record version 3.0.0
-        model_class.update_all({column=>name}, {primary_key=>uploader.model.send(primary_key)})
-      end
-      uploader.model.send :write_attribute, column, name
+      uploader.model.update_column(column, name)
     elsif defined?(Mongoid::Document) && uploader.model.is_a?(Mongoid::Document)
       # Mongoid support
       if Mongoid::VERSION.split(".").first.to_i >= 4