Feature: support backup.barmanObjectStore.s3Credentials.inheritFromIAMRole

[jessebot]

Fixes #487 and adds the following parameters to values.yaml:

backups:
  s3:
    inheritFromIAMRole: false

recovery:
  s3:
    inheritFromIAMRole: false

Please let me know if you need anything else from me!

[itay-grudev]

Is this required? Have you specified a correct serviceAccountTemplate?

[jessebot]

Yes, I tried with just the serviceAccountTemplate parameter set so it has the correct annotation, but if you don't have backup.barmanObjectStore.s3Credentials.inheritFromIAMRole, it still tries to use the s3 credentials unfortunately.

serviceAccountTemplate does actually template properly though, so that's good 👍

[jessebot]

It seems to also be included in the docs here:
https://cloudnative-pg.io/documentation/1.25/backup_volumesnapshot/#example

And here:
https://github.com/cloudnative-pg/cloudnative-pg/blob/995f3e247d8826687d556567488fa01fd9010d44/docs/src/samples/cluster-backup-aws-inherit.yaml#L14

[itay-grudev]

You are correct!

[itay-grudev]

The same option exist for Azure called inheritFromAzureAD which I seem to haved added to values, but not in _barman_object_store.tpl. Could you add it too as part of this PR?

[jessebot]

It looks like it's already there:

charts/charts/cluster/templates/_barman_object_store.tpl

Line 39 in 4bc725d

inheritFromAzureAD: true

Am I misunderstanding something? Is there more you'd like done? Happy to help, just a bit confused 🙏

[itay-grudev]

@jessebot I'm sorry about the confusion. For some reason I couldn't find it when running a full text search, but you're correct.

I'll try to release it next week along with several other things. Is that ok?

[jessebot]

That works fine for me. Thanks for getting back to me quickly and moving this forward! 🙏