feat: switch cache to be memory size based #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…instead of entry-based
domoritz
changed the title
domoritz
requested changes
Dec 4, 2024
|
|
||
| for (const [key, value] of cache) { | ||
| const { last } = value; | ||
| while (currSize > max) { |
There was a problem hiding this comment.
This is basically an if statement and would means we don't go into the loop if the size is not exceeded but we have expired items.
| } | ||
|
|
||
| return { | ||
| get(key) { | ||
| const entry = cache.get(key); | ||
| console.log("Size", currSize, cache.size) |
Comment on lines
+67
to
+71
| if (cache.has(key)) { | ||
| currSize -= cache.get(key).size; | ||
| } | ||
| cache.set(key, setValue); | ||
| currSize += setValue.size; |
There was a problem hiding this comment.
It's easier to not even set when the item already exists.
| @@ -22,14 +22,15 @@ class CacheEntry { | |||
|
|
|||
| export class Cache { | |||
There was a problem hiding this comment.
Can we remove this and use (or at least extend) the implementation from core utils?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change in Cache Mechanism: