Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the spelling of command. #342

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix the spelling of command. #342

wants to merge 1 commit into from

Conversation

Chaitanyassr
Copy link

fix issue #341

@akshatkarani
Copy link
Member

Change your commit message to follow commit guidelines. Also never open a PR from your master branch.

@Chaitanyassr
Copy link
Author

Change your commit message to follow commit guidelines. Also never open a PR from your master branch.

done, changed the message . for the branch part..i will keep this in mind in future .
or do you want me to open a different pr with a different branch for this one?

utkarsh2102
utkarsh2102 reviewed May 10, 2021
View reviewed changes
Copy link
Member

@utkarsh2102 utkarsh2102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey,

If you're still interested, just some trivial things:
-> add the issue being fixed in the commit messages.
-> rebase this PR, please.
-> [optional] in case you're interested, you can create a different branch and then change the base easily. You don't need a separate PR for sure!

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utkarsh2102 utkarsh2102 utkarsh2102 left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Chaitanyassr @akshatkarani @utkarsh2102