Skip to content

Commit

Permalink
Merge pull request #110 from codecademy-engineering/lindsay-1.8.8
Browse files Browse the repository at this point in the history
remove labels from pre-release-job pod spec
  • Loading branch information
lindsaylandry authored Nov 7, 2023
2 parents b26b236 + 66ffc89 commit 84f9bf8
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
2 changes: 1 addition & 1 deletion charts/service/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: service
description: A generic k8s service chart
type: application
version: 1.8.7
version: 1.8.8
maintainers:
- email: [email protected]
name: devops
4 changes: 3 additions & 1 deletion charts/service/templates/pre-release-job.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,13 @@ metadata:
"helm.sh/hook-weight": "0"
"helm.sh/hook-delete-policy": before-hook-creation
spec:
{{- if .ttlSecondsAfterFinished }}
ttlSecondsAfterFinished: {{ .ttlSecondsAfterFinished }}
{{- end }}
template:
metadata:
name: {{ include "service.fullname" . }}-pre-release-job
labels:
{{- include "service.labels" . | nindent 8 }}
{{- with .Values.datadog }}
tags.datadoghq.com/env: {{ .env }}
tags.datadoghq.com/service: {{ .service }}
Expand Down

0 comments on commit 84f9bf8

Please sign in to comment.