Skip to content

Commit

Permalink
Merge pull request #85 from codecademy-engineering/DEVOPS-5022-option…
Browse files Browse the repository at this point in the history
…al-service-object

[DEVOPS-5022] Optional service object
  • Loading branch information
anaharris authored Dec 5, 2022
2 parents 79aa6e8 + 54a430d commit 869f221
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 1 deletion.
2 changes: 1 addition & 1 deletion charts/service/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: service
description: A generic k8s service chart
type: application
version: 1.4.0
version: 1.5.0
maintainers:
- email: [email protected]
name: devops
3 changes: 3 additions & 0 deletions charts/service/ci/custom-values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ image:
- '-g'
- 'daemon off;'

service:
enabled: false

ingress:
enabled: true
annotations:
Expand Down
2 changes: 2 additions & 0 deletions charts/service/templates/service.yaml
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
{{- if .Values.service.enabled -}}
apiVersion: v1
kind: Service
metadata:
Expand All @@ -18,3 +19,4 @@ spec:
{{- end }}
selector:
{{- include "service.selectorLabels" . | nindent 4 }}
{{- end }}
1 change: 1 addition & 0 deletions charts/service/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ volumes: {}
# Defaults to port 80 on service resources
# DO NOT CHANGE, unless you absolutely need to
service:
enabled: true
type: ClusterIP
port: 80

Expand Down

0 comments on commit 869f221

Please sign in to comment.