Add globbing support

[lishaduck]

Fixes #770 for real (and fixes #1582).

Personally, I think this change belongs in the cli, but I decided that rewriting the argument parsing there was a much larger endeavor than this.
Tests are failing because it now globs the files, but they don't actually exist. I suppose we need fixtures then? Shouldn't be breaking in practice though.

[ssbarnea]

I can wait to see this merged. Interesting how the globbing was silently removed on each major version...

[lishaduck]

I tried deduping deps, but it only found duplicate devdeps, so the build didn't get any smaller 😢

[glen-84]

It might make sense to use @actions/glob, like @actions/upload-artifact does?

[lishaduck]

It might make sense to use @actions/glob, like @actions/upload-artifact does?

I hadn't heard of that, but yes, it looks like a better alternative.

[lishaduck]

@glen-84, I did a quick look at bundle size; for a PR that drastically increases the size of the the package, I feel it's worth trying to keep it down—@actions/glob is a 1.65MB minimatch wrapper, while tinyglobby is only 146KB.

[glen-84]

@lishaduck

That seems to be a known issue: actions/toolkit#1560, actions/toolkit#1697.

I suppose the one benefit of using the "official" package is that it's likely to already be installed. However, I don't feel strongly about it, and we can wait to see what the maintainers suggest. 🙂

[lishaduck]

I suppose the one benefit of using the "official" package is that it's likely to already be installed.

Actions are pre-bundled, it'd get reinstalled.

However, I don't feel strongly about it, and we can wait to see what the maintainers suggest. 🙂

They're currently doing a rewrite in bash, see #1591 (comment).

[glen-84]

Actions are pre-bundled, it'd get reinstalled.

Oh, that's a strange thing to do. 😕

They're currently doing a rewrite in bash, see #1591 (comment).

I saw this, but I misread it as being related to the eslint setup. 🙂

---

We've actually just switched to using the default file search mode where you don't specify the files. Probably not the most efficient, but it works for now.

[lishaduck]

Oh, that's a strange thing to do. 😕

Yeah, actions are weird.

We've actually just switched to using the default file search mode where you don't specify the files. Probably not the most efficient, but it works for now.

That's what I've been doing as well, works well enough for now.

[lishaduck]

Closing due to the v5 refactor; +1 #1582 instead.