Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put quotes around ${{ inputs.token }} in action.yml #1721

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

jwodder
Copy link
Contributor

@jwodder jwodder commented Dec 12, 2024

While debugging a "Token required because branch is protected" problem with two of my repositories, I noticed this in the codecov-action logs:

    if [ "false" == 'true' ];
    then
      # {"count":1984,"value":"***"}
      CC_TOKEN=$(curl -H "Authorization: bearer $ACTIONS_ID_TOKEN_REQUEST_TOKEN" "$ACTIONS_ID_TOKEN_REQUEST_URL&audience=https://codecov.io" | cut -d\" -f6)
      echo "CC_TOKEN=$CC_TOKEN" >> "$GITHUB_ENV"
    elif [ -n "" ];
    then
        echo "CC_TOKEN=" >> "$GITHUB_ENV"
    else
      if [ -n ***

     ];
      then
        CC_TOKEN=$(echo ***

     | tr -d '\n')
        echo "CC_TOKEN=$CC_TOKEN" >> "$GITHUB_ENV"
      fi
    fi
    shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
    env:
      CARGO_HOME: /home/runner/.cargo
      CARGO_INCREMENTAL: 0
      CARGO_TERM_COLOR: always
      CACHE_ON_FAILURE: false
    ##[endgroup]
    /home/runner/work/_temp/0f1d96ca-0f3a-423c-b405-fa68034346d8.sh: line 10: [: missing `]'
    /home/runner/work/_temp/0f1d96ca-0f3a-423c-b405-fa68034346d8.sh: line 12: ]: command not found

Note the newline in the middle of if [ -n *** ] and the error messages at the bottom. Earlier in my debugging, I had determined that the CODECOV_TOKEN secret (which I don't have permission to change) contained two trailing newlines, and it seems action.yml doesn't handle those right due to a lack of quotes around ${{inputs.token}}. This PR fixes this.

Fixes #1694.

@thomasrockhu-codecov thomasrockhu-codecov merged commit 34ef570 into codecov:main Dec 16, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bash throws syntax error if inputs.token contains a newline character
2 participants