Put quotes around ${{ inputs.token }}
in action.yml
#1721
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While debugging a "Token required because branch is protected" problem with two of my repositories, I noticed this in the codecov-action logs:
Note the newline in the middle of
if [ -n *** ]
and the error messages at the bottom. Earlier in my debugging, I had determined that theCODECOV_TOKEN
secret (which I don't have permission to change) contained two trailing newlines, and it seemsaction.yml
doesn't handle those right due to a lack of quotes around${{inputs.token}}
. This PR fixes this.Fixes #1694.