PlanService updates for GitLab

[nora-codecov]

update PlanService so GitLab orgs use the root org's plan, fold is_pr_billing_plan into PlanService

IF an OwnerOrg is a GitLab subgroup OR has an Account, the plan on the OwnerOrg is not the one we want to use! We want the plan on the root Org or Account object instead.

PlanService already had the smarts to check for an Account and get the Account plan, but now it also has the smarts to check whether a GitLab OwnerOrg has a parent, then use the plan from the root Org.

Part of codecov/engineering-team#2710

[nora-codecov]

does anyone know why these Plans aren't in the BillingPlan enum? Seems like an oversight...
@ajay-sentry @RulaKhaled since you two have been in the PlanService lately 🙏

[nora-codecov]

Talked with Ajay, this is an oversight, adding to BillingPlan

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.96%. Comparing base (609e56d) to head (9e55b8a).

❗ Current head 9e55b8a differs from pull request most recent head 990c398

Please upload reports for the commit 990c398 to get more accurate results.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #461      +/-   ##
==========================================
- Coverage   90.55%   89.96%   -0.59%     
==========================================
  Files         404      324      -80     
  Lines       12562     9189    -3373     
  Branches     2107     1633     -474     
==========================================
- Hits        11375     8267    -3108     
+ Misses       1078      859     -219     
+ Partials      109       63      -46     

Flag	Coverage Δ
shared-docker-uploader	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[giovanni-guidini]

Maybe it's worth to mark it as deprecated?

[giovanni-guidini]

This doesn't seem correct... you are checking for current_org.parent_service_id not being None, but self.current_org is getting the value of current_org.root_organization

[nora-codecov]

it's correct, just confusing 🙃
We want the root org. The way you know if the current_org is the root org is parent_service_id field.
if current_org.parent_service_id, it means it is not the root org.
parent and root are not necessarily the same org - GL orgs can have multiple levels of groups and subgroups.
So if you know that you don't have the root org (by checking current_org.parent_service_id), then get the root org with .root_organization, a helper function on the model.