[CCAP-645] - implements temporary-provider-response-confirmation (#1118)

codeforamerica · Feb 5, 2025 · 9d58669 · 9d58669
1 parent ed64ba8
commit 9d58669
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 82 deletions.
diff --git a/src/main/resources/flows-config.yaml b/src/main/resources/flows-config.yaml
@@ -640,16 +640,6 @@ flow:
     nextScreens:
       - name: registration-contact-info
   registration-contact-info:
-    nextScreens:
-      # Temporary until we have a way to download PDF in providerresponse flow
-      # Confirmation code is needed to DL PDF since its how we get the family submission
-      # TODO: change this when we've figured out above comments and delete the temporary-provider-response-confirmation-code-fix screen
-      - name: temporary-provider-response-confirmation-code-fix
-#      - name: registration-info-review
-  temporary-provider-response-confirmation-code-fix:
-    crossFieldValidationAction: ValidateConfirmationCodeAndSaveId
-    afterSaveAction: CheckClientSubmissionForProvider
-    onPostAction: GenerateDummyClientSubmissionForDev
     nextScreens:
       - name: registration-info-review
   registration-info-review:

diff --git a/...sources/templates/providerresponse/temporary-provider-response-confirmation-code-fix.html b/...sources/templates/providerresponse/temporary-provider-response-confirmation-code-fix.html
diff --git a/src/test/java/org/ilgcc/app/journeys/ProviderresponseProviderRegistrationJourneyTest.java b/src/test/java/org/ilgcc/app/journeys/ProviderresponseProviderRegistrationJourneyTest.java
@@ -83,12 +83,6 @@ void BasicInfoFlow() {
         testPage.enter("providerResponseContactEmail", "[email protected]");
         testPage.clickContinue();
 
-        // Temporary Confirmation Code
-        // TODO - Remove this when we have a solution for downloading the PDF in the provider response flow
-        assertThat(testPage.getTitle()).isEqualTo(getEnMessage("provider-response-confirmation-code.title"));
-        testPage.enter("providerResponseFamilyShortCode", CONF_CODE);
-        testPage.clickContinue();
-
         // registration-info-review
         assertThat(testPage.getTitle()).isEqualTo(getEnMessage("provider-response-info-review.title"));
         assertThat(testPage.findElementTextById("provider-full-name")).isEqualTo("ProviderFirst ProviderLast");
@@ -188,13 +182,8 @@ void LicenseExemptInProviderHomeFlow() {
         testPage.enter("providerResponseContactEmail", "[email protected]");
         testPage.clickContinue();
 
-        // Temporary Confirmation Code
-        // TODO - Remove this when we have a solution for downloading the PDF in the provider response flow
-        assertThat(testPage.getTitle()).isEqualTo(getEnMessage("provider-response-confirmation-code.title"));
-        testPage.enter("providerResponseFamilyShortCode", CONF_CODE);
-        testPage.clickContinue();
-
         // registration-info-review
+        assertThat(testPage.getTitle()).isEqualTo(getEnMessage("provider-response-info-review.title"));
         testPage.clickContinue();
 
         // registration-home-provider-ssn
@@ -439,13 +428,8 @@ void LicenseExemptInChildHomeFlow() {
         testPage.enter("providerResponseContactEmail", "[email protected]");
         testPage.clickContinue();
 
-        // Temporary Confirmation Code
-        // TODO - Remove this when we have a solution for downloading the PDF in the provider response flow
-        assertThat(testPage.getTitle()).isEqualTo(getEnMessage("provider-response-confirmation-code.title"));
-        testPage.enter("providerResponseFamilyShortCode", CONF_CODE);
-        testPage.clickContinue();
-
         // registration-info-review
+        assertThat(testPage.getTitle()).isEqualTo(getEnMessage("provider-response-info-review.title"));
         testPage.clickContinue();
 
         // registration-home-provider-ssn
@@ -602,13 +586,8 @@ void LicensedChildCareHomeFlow() {
         testPage.enter("providerResponseContactEmail", "[email protected]");
         testPage.clickContinue();
 
-        // Temporary Confirmation Code
-        // TODO - Remove this when we have a solution for downloading the PDF in the provider response flow
-        assertThat(testPage.getTitle()).isEqualTo(getEnMessage("provider-response-confirmation-code.title"));
-        testPage.enter("providerResponseFamilyShortCode", CONF_CODE);
-        testPage.clickContinue();
-
         // registration-info-review
+        assertThat(testPage.getTitle()).isEqualTo(getEnMessage("provider-response-info-review.title"));
         testPage.clickContinue();
 
         // registration-home-provider-ssn
@@ -761,13 +740,8 @@ void LicensedChildCareCenterFlow() {
         testPage.enter("providerResponseContactEmail", "[email protected]");
         testPage.clickContinue();
 
-        // Temporary Confirmation Code
-        // TODO - Remove this when we have a solution for downloading the PDF in the provider response flow
-        assertThat(testPage.getTitle()).isEqualTo(getEnMessage("provider-response-confirmation-code.title"));
-        testPage.enter("providerResponseFamilyShortCode", CONF_CODE);
-        testPage.clickContinue();
-
         // registration-info-review
+        assertThat(testPage.getTitle()).isEqualTo(getEnMessage("provider-response-info-review.title"));
         testPage.clickContinue();
 
         //registration-tax-id.title
@@ -902,13 +876,8 @@ void LicensedGroupChildCareHomeFlow() {
         testPage.enter("providerResponseContactEmail", "[email protected]");
         testPage.clickContinue();
 
-        // Temporary Confirmation Code
-        // TODO - Remove this when we have a solution for downloading the PDF in the provider response flow
-        assertThat(testPage.getTitle()).isEqualTo(getEnMessage("provider-response-confirmation-code.title"));
-        testPage.enter("providerResponseFamilyShortCode", CONF_CODE);
-        testPage.clickContinue();
-
         // registration-info-review
+        assertThat(testPage.getTitle()).isEqualTo(getEnMessage("provider-response-info-review.title"));
         testPage.clickContinue();
 
         // registration-home-provider-ssn
@@ -1074,12 +1043,6 @@ void LicenseExemptChildCareCenter() {
         testPage.enter("providerResponseContactEmail", "[email protected]");
         testPage.clickContinue();
 
-        // Temporary Confirmation Code
-        // TODO - Remove this when we have a solution for downloading the PDF in the provider response flow
-        assertThat(testPage.getTitle()).isEqualTo(getEnMessage("provider-response-confirmation-code.title"));
-        testPage.enter("providerResponseFamilyShortCode", CONF_CODE);
-        testPage.clickContinue();
-
         // registration-info-review
         assertThat(testPage.getTitle()).isEqualTo(getEnMessage("provider-response-info-review.title"));
         assertThat(testPage.findElementTextById("provider-full-name")).isEqualTo("ProviderFirst ProviderLast");