[CCAP-671] Clean up for a few CodeQL warnings in github (#1154)

codeforamerica · Feb 13, 2025 · f14778c · f14778c
1 parent b336882
commit f14778c
Show file tree

Hide file tree

Showing 4 changed files with 31 additions and 4 deletions.
diff --git a/src/main/java/org/ilgcc/app/data/Provider.java b/src/main/java/org/ilgcc/app/data/Provider.java
@@ -64,4 +64,18 @@ public class Provider implements Serializable {
     @OnDelete(action = OnDeleteAction.CASCADE)
     @ManyToOne
     private ResourceOrganization resourceOrganization;
+
+    @Override
+    public String toString() {
+        return "Provider{" +
+                "providerId=" + providerId +
+                ", type='" + type + '\'' +
+                ", city='" + city + '\'' +
+                ", state='" + state + '\'' +
+                ", zipCode='" + zipCode + '\'' +
+                ", status='" + status + '\'' +
+                ", dateOfLastApproval=" + dateOfLastApproval +
+                ", resourceOrganization=" + resourceOrganization +
+                '}';
+    }
 }
diff --git a/src/main/java/org/ilgcc/app/data/ResourceOrganization.java b/src/main/java/org/ilgcc/app/data/ResourceOrganization.java
@@ -48,4 +48,17 @@ public class ResourceOrganization {
 
     @OneToMany(mappedBy = "resourceOrganization", fetch =FetchType.LAZY)
     private Set<Provider> providers;
+
+    @Override
+    public String toString() {
+        return "ResourceOrganization{" +
+                "sda=" + sda +
+                ", email='" + email + '\'' +
+                ", phone='" + phone + '\'' +
+                ", address='" + address + '\'' +
+                ", name='" + name + '\'' +
+                ", caseloadCode='" + caseloadCode + '\'' +
+                ", resourceOrgId=" + resourceOrgId +
+                '}';
+    }
 }
diff --git a/src/main/java/org/ilgcc/app/pdf/ProviderApplicationPreparer.java b/src/main/java/org/ilgcc/app/pdf/ProviderApplicationPreparer.java
@@ -35,14 +35,14 @@ public Map<String, SubmissionField> prepareSubmissionFields(Submission submissio
         }
 
         if (useProviderResponse(submission)) {
-            return prepareProviderResponse(submission);
+            return prepareProviderResponse();
         } else {
             return prepareFamilyIntendedProviderData(submission);
         }
     }
 
-    //Because we are printing the PDF from the GCC flow we need to get the provider submission then pull the responses values from the provdier submission
-    private Map<String, SubmissionField> prepareProviderResponse(Submission submission) {
+    //Because we are printing the PDF from the GCC flow we need to get the provider submission then pull the responses values from the provider submission
+    private Map<String, SubmissionField> prepareProviderResponse() {
         var results = new HashMap<String, SubmissionField>();
 
         Map<String, Object> providerInputData = providerSubmission.getInputData();

diff --git a/src/main/java/org/ilgcc/app/utils/ZipcodeOption.java b/src/main/java/org/ilgcc/app/utils/ZipcodeOption.java
@@ -396,7 +396,7 @@ public static Boolean isValidZipcodeOption(String zipcode, Boolean includeSDA15)
     }
 
     public static Optional<String> getCaseLoadCodeByZipCode(String zipcode) {
-        Boolean hasZip = ZIPCODE_MAP.containsKey(zipcode);
+        boolean hasZip = ZIPCODE_MAP.containsKey(zipcode);
         return hasZip ? Optional.of(ZIPCODE_MAP.get(zipcode)) : Optional.empty();
     }
 }