[CCAP-642] - Sends confirmation email when provider agrees to care #1171

analoo · 2025-02-18T21:57:25Z

🔗 Jira ticket

CCAP-642

✍️ Description

Creates a new email class ILGCCEmail
Creates new SendGrid email signatures that allow the value to be passed
Adds tests
Sends Email to provider

📷 Design reference

✅ Completion tasks

Added relevant tests
Meets acceptance criteria

src/main/java/org/ilgcc/app/submission/actions/SendProviderConfirmationEmail.java

enyia21

Small nits but good to go

src/main/resources/messages.properties

spokenbird · 2025-02-19T00:44:37Z

src/main/java/org/ilgcc/app/email/SendGridEmailService.java

@@ -21,7 +21,7 @@ public class SendGridEmailService {
    private final SendGrid sendGrid = new SendGrid(System.getenv("SENDGRID_API_KEY"));

    public Response sendEmail(String recipientAddress, String senderName, String subject, Content content) throws IOException {


Should we just delete the top sendEmail method in favor of the one that accepts ILGCCEmail instead of overloading?

Yes - we just need to move the other actions to the new sendEmail class. I didn't make the change here because the ticket was already getting pretty big and I wanted to get a thumbs up on the new approach first.

src/main/java/org/ilgcc/app/submission/actions/SendProviderConfirmationEmail.java

src/main/java/org/ilgcc/jobs/SendEmailJob.java

src/main/resources/messages.properties

cram-cfa

When you're all done with the other comments/changes, can you also make sure you run the IntelliJ formatter and make sure everything has the correct spacing, etc? Thanks!

src/main/java/org/ilgcc/app/submission/actions/SendProviderConfirmationEmail.java

cram-cfa · 2025-02-19T22:04:50Z

src/main/java/org/ilgcc/app/utils/ProviderSubmissionUtilities.java

+        } else {
+            // More than 2 childrenInitials, use comma for all but the last one
+            String last = childrenInitials.remove(childrenInitials.size() - 1); // Remove and keep the last name
+            return String.join(", ", childrenInitials) + " and " + last; // Join remaining with commas, append 'and last'


How does this method work for Spanish (or other future languages)?

Good point. This does not support Spanish currently and neither does the original implementation. I'll fix it.

I guess for spanish, since the actual way this would be written doesn't vary, you could just pull a single string of "and" vs "y" ... right?

(this would all fall apart if we were doing like... Arabic?)

yes - you are correct for Spanish. It would probably break in other languages.

cool, let's just worry about Spanish and when we run into another language where this doesn't work -- and that's probably a non-western/non-latin based language -- we can worry about it. And by "we" I mean "someone else in the future who is probably not us" 😎

cram-cfa · 2025-02-19T22:08:11Z

src/test/java/org/ilgcc/app/submission/actions/SendProviderConfirmationEmailTest.java

+
+        String emailCopy = action.setBodyCopy(emailData, Locale.ENGLISH);
+
+        assertThat(emailCopy).contains(


It seems weird to me that we have tests that are now dependent on hardcoded strings; I thought we decided to stop hardcoding text and instead wanted to load things from the messages.properties?

That's fair. I can update the tests to use the message keys instead of the hard coded strings.

Not a big deal, just wanted to consistent.

…copies of hard strings in tests

addressed feedback

analoo marked this pull request as ready for review February 18, 2025 21:57

analoo requested a review from enyia21 February 18, 2025 21:57

github-actions bot assigned analoo Feb 18, 2025

github-actions bot requested a review from cram-cfa February 18, 2025 21:57

enyia21 temporarily deployed to il-gcc-ccap-643-provide-amuuk0 February 18, 2025 21:58 Inactive

analoo requested review from spokenbird and removed request for cram-cfa February 18, 2025 21:59

github-advanced-security bot found potential problems Feb 18, 2025

View reviewed changes

src/main/java/org/ilgcc/app/submission/actions/SendProviderConfirmationEmail.java Fixed Show fixed Hide fixed

src/main/java/org/ilgcc/app/submission/actions/SendProviderConfirmationEmail.java Fixed Show fixed Hide fixed

analoo force-pushed the CCAP-643-provider-confirmation-email branch from cce87d9 to 68e897a Compare February 18, 2025 22:05

enyia21 temporarily deployed to il-gcc-ccap-643-provide-amuuk0 February 18, 2025 22:05 Inactive

analoo changed the title ~~[CCAP-643] - Sends confirmation email when provider agrees to care~~ [CCAP-642] - Sends confirmation email when provider agrees to care Feb 18, 2025

analoo added the Ready For Review label Feb 18, 2025

mtodd-cfa reviewed Feb 18, 2025

View reviewed changes

src/main/java/org/ilgcc/app/submission/actions/SendProviderConfirmationEmail.java Show resolved Hide resolved

enyia21 approved these changes Feb 19, 2025

View reviewed changes

src/main/resources/messages.properties Show resolved Hide resolved

src/main/resources/messages.properties Outdated Show resolved Hide resolved

spokenbird previously requested changes Feb 19, 2025

View reviewed changes

cram-cfa requested changes Feb 19, 2025

View reviewed changes

src/main/java/org/ilgcc/app/submission/actions/SendProviderConfirmationEmail.java Outdated Show resolved Hide resolved

analoo added Work in Progress and removed Ready For Review labels Feb 19, 2025

analoo added 2 commits February 19, 2025 13:22

[CCAP-643] - Sends confirmation email when provider agrees to care

ab8be73

Fixes formatting and SkipEmail logic

4bee67f

enyia21 temporarily deployed to il-gcc-ccap-643-provide-amuuk0 February 19, 2025 21:22 Inactive

analoo force-pushed the CCAP-643-provider-confirmation-email branch from 4065942 to 4bee67f Compare February 19, 2025 21:23

enyia21 temporarily deployed to il-gcc-ccap-643-provide-amuuk0 February 19, 2025 21:24 Inactive

analoo added Ready For Review and removed Work in Progress labels Feb 19, 2025

cram-cfa reviewed Feb 19, 2025

View reviewed changes

Removes hard coded 'and' to make full email translatable and removes …

682091a

…copies of hard strings in tests

enyia21 temporarily deployed to il-gcc-ccap-643-provide-amuuk0 February 19, 2025 23:30 Inactive

cram-cfa approved these changes Feb 19, 2025

View reviewed changes

Updates action method signature to match other email actions

e93e2a3

enyia21 temporarily deployed to il-gcc-ccap-643-provide-amuuk0 February 19, 2025 23:41 Inactive

analoo merged commit c836223 into main Feb 20, 2025
5 checks passed

analoo deleted the CCAP-643-provider-confirmation-email branch February 20, 2025 02:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CCAP-642] - Sends confirmation email when provider agrees to care #1171

[CCAP-642] - Sends confirmation email when provider agrees to care #1171

analoo commented Feb 18, 2025 •

edited by jira bot

Loading

enyia21 left a comment

spokenbird Feb 19, 2025

analoo Feb 19, 2025

cram-cfa left a comment

cram-cfa Feb 19, 2025

analoo Feb 19, 2025

cram-cfa Feb 19, 2025

analoo Feb 19, 2025

cram-cfa Feb 19, 2025

cram-cfa Feb 19, 2025

analoo Feb 19, 2025

cram-cfa Feb 19, 2025

		@@ -21,7 +21,7 @@ public class SendGridEmailService {
		private final SendGrid sendGrid = new SendGrid(System.getenv("SENDGRID_API_KEY"));

		public Response sendEmail(String recipientAddress, String senderName, String subject, Content content) throws IOException {


		String emailCopy = action.setBodyCopy(emailData, Locale.ENGLISH);

		assertThat(emailCopy).contains(

[CCAP-642] - Sends confirmation email when provider agrees to care #1171

[CCAP-642] - Sends confirmation email when provider agrees to care #1171

Conversation

analoo commented Feb 18, 2025 • edited by jira bot Loading

🔗 Jira ticket

✍️ Description

📷 Design reference

✅ Completion tasks

enyia21 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cram-cfa left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

analoo commented Feb 18, 2025 •

edited by jira bot

Loading