changed NJ intake to has_many analytics (#5554)

* changed NJ intake to has_many analytics * tweaks how StateFileNjAnalytics object is created and associated to the source intake in the analytic-making background job * Added test for multiple submissions on one intake --------- Co-authored-by: jey <[email protected]>
codeforamerica · Feb 11, 2025 · c75ad16 · c75ad16
1 parent eff711d
commit c75ad16
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 2 deletions.
diff --git a/app/jobs/state_file/create_nj_analytics_record_job.rb b/app/jobs/state_file/create_nj_analytics_record_job.rb
@@ -2,7 +2,7 @@ module StateFile
   class CreateNjAnalyticsRecordJob < ApplicationJob
     def perform(submission_id)
       submission = EfileSubmission.find(submission_id)
-      nj_analytics = submission.data_source.create_state_file_nj_analytics!
+      nj_analytics = StateFileNjAnalytics.create(state_file_nj_intake: submission.data_source)
       nj_analytics&.update(nj_analytics.calculated_fields)
     end
 

diff --git a/app/models/state_file_nj_intake.rb b/app/models/state_file_nj_intake.rb
@@ -114,7 +114,7 @@
 class StateFileNjIntake < StateFileBaseIntake
   self.ignored_columns += ["primary_signature_pin", "spouse_signature_pin"]
   encrypts :account_number, :routing_number, :raw_direct_file_data, :raw_direct_file_intake_data
-  has_one :state_file_nj_analytics
+  has_many :state_file_nj_analytics
 
   enum household_rent_own: { unfilled: 0, rent: 1, own: 2, neither: 3, both: 4 }, _prefix: :household_rent_own
 

diff --git a/spec/jobs/state_file/create_nj_analytics_record_job_spec.rb b/spec/jobs/state_file/create_nj_analytics_record_job_spec.rb
@@ -11,5 +11,16 @@
       submitted_intake.reload
       expect(submitted_intake.state_file_nj_analytics).to be_present
     end
+
+    context "when multiple submissions exist" do
+      let!(:submission_2) { create :efile_submission, :for_state, data_source: submitted_intake }
+      it "allows multiple NJ analytics records to be attached to one intake" do
+        expect(submitted_intake.state_file_nj_analytics).not_to be_present
+        described_class.perform_now(submission.id)
+        submitted_intake.reload
+        described_class.perform_now(submission_2.id)
+        expect(submitted_intake.state_file_nj_analytics.size).to eq 2
+      end
+    end
   end
 end