Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FYST-1631 1099R subtractable calculations + PDF/XML #5576

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

FYST-1631 1099R subtractable calculations + PDF/XML #5576

wants to merge 7 commits into from
+234 −83

Conversation

arinchoi03
Copy link
Contributor

@arinchoi03 arinchoi03 commented Feb 12, 2025 •
edited
Loading

Link to pivotal/JIRA issue

Is PM acceptance required? (delete one)

  • Yes - don't merge until JIRA issue is accepted!

Reminder: merge main into this branch and get green tests before merging to main

What was done?

  • Apply calculations for line 29a and line 29b from the az follow ups
  • add tests for xml/pdf for these lines (already implemented)

How to test?

  • Describe the testing approach taken to verify the changes, including:
    • Unit/integration/manual tests
    • Test data used: currently program is generating the examples that would go through different test cases
      • Tycho single has one 1099R
      • Jojo MFS has two 1099Rs with values over 2500 for each spouse

Screenshots (for visual changes)

Screenshot 2025-02-12 at 3 30 37 PM Screenshot 2025-02-12 at 3 31 16 PM Screenshot 2025-02-12 at 3 33 03 PM Screenshot 2025-02-12 at 3 32 55 PM

arinchoi03
arinchoi03 commented Feb 12, 2025
View reviewed changes
spec/models/state_file_base_intake_spec.rb
end
end
end

Copy link
Contributor Author

@arinchoi03 arinchoi03 Feb 12, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved these tests over b/c the methods moved over from MD intake -> base intake

arinchoi03
arinchoi03 commented Feb 12, 2025
View reviewed changes
app/models/state_file_base_intake.rb
end
end
end

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

simply moved over from state file md intake

@github-actions GitHub Actions
Copy link

Heroku app: https://gyr-review-app-5576-ea1be34e175b.herokuapp.com/
View logs: heroku logs --app gyr-review-app-5576 (optionally add --tail)

@anisharamnani
Copy link
Contributor

I really appreciate the thoroughness of your PRs! They are very detailed and therefore make things easy to follow & understand.

...I was wondering if these calculations need to be behind a Flipper Flag. I can do some digging too.

anisharamnani
anisharamnani approved these changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@anisharamnani anisharamnani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭐

@arinchoi03
Copy link
Contributor Author

had convo:

fwiw I'm guessing it'll all return 0 for the 1099R amounts since the followup ui for determining income_source isn't turned on RetirementIncomeSubtractionController but probably doesn't hurt to have explicit logic (asking Tiffany here)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anisharamnani anisharamnani anisharamnani approved these changes

Assignees
No one assigned
Labels
in-acceptance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arinchoi03 @anisharamnani