Issue 75 create api view for completing a challenge #127
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| if image and tile.consent: | ||
| tile.image = image |
There was a problem hiding this comment.
You don't need to check for consent here. The point of the consent field is to track whether the user gives permission for the image to be shared on Blue Crew's social media. So the image the user uploads should be stored regardless.
| 'full_bingo' contains a boolean, representing whether the full grid has been completed. | ||
| """ | ||
| active_grid = get_object_or_404(BingoGrid, is_active=True) | ||
| serializer = ChallengeCompleteSerializer(request.data) |
There was a problem hiding this comment.
I think you'll want to call serializer.is_valid(). Otherwise, there isn't much point of a serializer -- you could just use request.data everywhere you are using serializer.data.
| tile the diagonal contains, either 0 or 3, -1 if no bingo. | ||
| 'full_bingo' contains a boolean, representing whether the full grid has been completed. | ||
| """ | ||
| active_grid = get_object_or_404(BingoGrid, is_active=True) |
There was a problem hiding this comment.
Not a big deal, but I think it would make more sense to return a 500 error here. If there no active BingoGrid, then something has gone very wrong on the server's side.
| user = get_object_or_404(User, is_active=True, | ||
| user_id=tile.user.user_id) |
There was a problem hiding this comment.
Does request.user work instead here?
Change Summary
Added a view to complete a challenge, and give the user any points they've gotten from completing the challenge, as well as any bingos they have achieved.
Change Form
Fill this up (NA if not available). If a certain criteria is not met, can you please give a reason.
Other Information
: )
Related issue