Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 99 fix further issues with rsvp endpoint #100

Merged
merged 4 commits into from
Jul 26, 2024
Merged

Issue 99 fix further issues with rsvp endpoint #100

merged 4 commits into from
Jul 26, 2024

Conversation

harryrigg
Copy link
Collaborator

@harryrigg harryrigg commented Jul 26, 2024 •
edited by github-actions bot
Loading

Change Summary

  • Fix endpoint for creating RSVP for a given event.
  • Add a DELETE endpoint that allows deleting the users RSVP for a given event.
  • Rename event RSVP view function.

Other Information

Potentially more work to done on this in the future, however just need this to work for now so I can finish with connecting event page to backend.

  • Might make more sense to persist an RSVP instance but add an 'active' flag to the model. That way the system won't cycle through ID's if a user RSVP's and unRSVP's to an event multiple times.
  • Could simplify things if we just added an endpoint to toggle the status of the users RSVP to an event.
  • I'm not sure if we are even using the rsvp_detail endpoint so this could potentially be removed.

Related issue

@harryrigg harryrigg added backend Task must have a back end issue bug Something isn't working enhancement New feature or request labels Jul 26, 2024
@harryrigg harryrigg requested a review from dct0 July 26, 2024 16:39
@harryrigg harryrigg self-assigned this Jul 26, 2024
@vercel Vercel
Copy link

vercel bot commented Jul 26, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
coexist ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 26, 2024 4:39pm

@harryrigg harryrigg merged commit 05d5b40 into main Jul 26, 2024
8 checks passed
@harryrigg harryrigg deleted the issue-99-Fix_further_issues_with_RSVP_endpoint branch July 26, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dct0 dct0 dct0 approved these changes

Assignees

@harryrigg harryrigg

Labels
backend Task must have a back end issue bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix further issues with RSVP endpoint
2 participants
@harryrigg @dct0