Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restyle Event Card. Make other changes on front end #131

Merged
merged 2 commits into from
Nov 23, 2024

Conversation

harryrigg
Copy link
Collaborator

@harryrigg harryrigg commented Nov 6, 2024

  • Redesigned the event card. Looks good on all screen sizes, and all edge cases are accounted for (e.g. long description, no image, multiple days).
    • For multi day events, decided against showing the end date on mobile to avoid clutter. In this case, only the start time is shown to avoid confusion.
  • Added an event list component, in case we decide to list events on multiple pages.
  • Added an RSVP button component. Automatically handles updating RSVP status for the given event. Shows a toast to users confirming their decision.
    • Placed on the event page, and the event card.
  • Fixed an issue where the user query was not immediately invalidated on login/logout.
  • Unrelated, but I added a hook that can be used to delay showing loading indicators. Prevents flicker and provides a better user experience. Implemented it with the RSVP button but still needs to be setup with the other forms.
  • Also unrelated, I modified the root layout component so that all pages now have consistent margins and a maximum width for large screen sizes.
image image image image

Related issue

Copy link

vercel bot commented Nov 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
coexist ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 8, 2024 1:19pm

@harryrigg harryrigg requested review from dct0 and K-Straiton November 6, 2024 15:24
@harryrigg
Copy link
Collaborator Author

This also closes issue #96

Copy link
Contributor

@K-Straiton K-Straiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Lgtm!

@K-Straiton K-Straiton merged commit 01b8f57 into main Nov 23, 2024
7 checks passed
@K-Straiton K-Straiton deleted the issue-130-Fix_styling_and_links_on_event_cards branch November 23, 2024 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix styling and links on event cards
2 participants