Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 33 create edit profile modal #95

Merged
merged 48 commits into from
Aug 3, 2024
Merged

Issue 33 create edit profile modal #95

merged 48 commits into from
Aug 3, 2024

Conversation

ellenxxxiao
Copy link
Collaborator

@ellenxxxiao ellenxxxiao commented Jul 22, 2024 •
edited by github-actions bot
Loading

Change Summary

  • Edit profile modal
  • Change password modal

Change Form

  • The pull request title has an issue number
  • The change works by "Smoke testing" or quick testing
  • The change has tests
  • The change has documentation

Other Information

  • Mock data is used for user name, avatar, branch. Another issue is needed to connect with the backend.
  • The modal does not close when submit button is clicked. A fix is commented out atm.

Related issue

ellenxxxiao and others added 30 commits June 29, 2024 07:39
@ellenxxxiao
modal basic structure
9d93d47
@ellenxxxiao
icon
91f4437
@ellenxxxiao
changed open modal button to edit icon
800ebac
@ellenxxxiao
width + form box
72827e0
@KKatariah
rounded text boxes and placed divider
610bf6f
@ellenxxxiao
cross button size
695af0a
@ellenxxxiao
avatar, colors (change to tailwind colours later)
26325df
@ellenxxxiao
Merge branch 'main' of https://github.com/codersforcauses/coexist int…
8b94771 
…o issue-33-Create_edit_profile_modal
@ellenxxxiao
Merge branch 'main' of https://github.com/codersforcauses/coexist int…
06580e2 
…o issue-33-Create_edit_profile_modal
@KKatariah
Merge branch 'main' of https://github.com/codersforcauses/coexist int…
75bdf57 
…o issue-33-Create_edit_profile_modal
@KKatariah
added grid formatting
f670de9
@ellenxxxiao
Merge branch 'issue-33-Create_edit_profile_modal' of https://github.c…
b78a9ac 
…om/codersforcauses/coexist into issue-33-Create_edit_profile_modal
@KKatariah
installed required shadui components for form
7b398b3
@ellenxxxiao
Merge branch 'issue-33-Create_edit_profile_modal' of https://github.c…
101971f 
…om/codersforcauses/coexist into issue-33-Create_edit_profile_modal
@KKatariah
adjusting popup size
12e833f
@KKatariah
Merge branch 'issue-33-Create_edit_profile_modal' of https://github.c…
09d8c64 
…om/codersforcauses/coexist into issue-33-Create_edit_profile_modal
@ellenxxxiao
dropdown for city + change pwd link
3b3b11f
@ellenxxxiao
Merge branch 'main' of https://github.com/codersforcauses/coexist int…
5d0be13 
…o issue-33-Create_edit_profile_modal
@ellenxxxiao
mobile
76e02e9
@ellenxxxiao
fixed cross position
5623af0
@ellenxxxiao
responsive to larger screens
88bdb2e
@ellenxxxiao
- working form submission
ba6f1dd 
- styling for both mobile & larger screens
- dropdown branch select
@ellenxxxiao
cross size + position
5a9762a
@ellenxxxiao
change password modal.
ac2b250 
** FIXME: reset form inputs when modal lost focus
@ellenxxxiao
Merge branch 'main' of https://github.com/codersforcauses/coexist int…
6d7dc48 
…o issue-33-Create_edit_profile_modal
@ellenxxxiao
- fix nested form submit issue
5ce1ece 
- update branch schema
@ellenxxxiao
styling, relocate submit button
24483b2
@ellenxxxiao
Merge branch 'main' of https://github.com/codersforcauses/coexist int…
f6dd6ab 
…o issue-33-Create_edit_profile_modal
@ellenxxxiao
rmved duplicate lines
85a5fc3
@ellenxxxiao
duplicate
e58d94b
ellenxxxiao and others added 16 commits July 20, 2024 04:51
@ellenxxxiao
merged migrations for branch
5b812ce
@ellenxxxiao
added /test-page to public path
fe560e2
@KKatariah
alignment of buttons, etc
cc66cc9
@ellenxxxiao
fixed unaligned labels, shrink margin
b2c2c6e
@KKatariah
updated change password modal on md screens
53cb836
@KKatariah
Merge branch 'issue-33-Create_edit_profile_modal' of https://github.c…
e7ec651 
…om/codersforcauses/coexist into issue-33-Create_edit_profile_modal
@ellenxxxiao
re styled the submit button
4ee1adb
@KKatariah
added phone number field
0761ec5
@KKatariah
made md tablet screens use sm mobile styling
5b6d05e
@KKatariah
Merge branch 'issue-33-Create_edit_profile_modal' of https://github.c…
b364f73 
…om/codersforcauses/coexist into issue-33-Create_edit_profile_modal
@KKatariah
removed FIXME message since phone is validated on the backend
688abdd
@ellenxxxiao
refactored to use a map
f8c08bf
@ellenxxxiao
Merge branch 'issue-33-Create_edit_profile_modal' of https://github.c…
f4ccd43 
…om/codersforcauses/coexist into issue-33-Create_edit_profile_modal
@ellenxxxiao
refactored edit profile modal; added key for map in change pwd modal
d7d33d9
@ellenxxxiao
removed unused variables
c8be145
@ellenxxxiao
Merge branch 'main' of https://github.com/codersforcauses/coexist int…
a3c8994 
…o issue-33-Create_edit_profile_modal
@vercel Vercel
Copy link

vercel bot commented Jul 22, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
coexist ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 25, 2024 5:49am

@KKatariah KKatariah requested review from dct0 and K-Straiton July 24, 2024 06:24
@K-Straiton K-Straiton merged commit 09d3376 into main Aug 3, 2024
7 checks passed
@K-Straiton K-Straiton deleted the issue-33-Create_edit_profile_modal branch August 3, 2024 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dct0 dct0 dct0 approved these changes

@K-Straiton K-Straiton Awaiting requested review from K-Straiton

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create edit profile modal
4 participants
@ellenxxxiao @dct0 @K-Straiton @KKatariah