Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 165 refactor users page #230

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

justinliangg
Copy link
Collaborator

@justinliangg justinliangg commented Feb 18, 2024

Change Summary

  • Refactored the user's service to use the staff tables for roles instead. This now allows a "role" filter for the users endpoint.
  • Have moved the auth check for the pages to a withProtected component instead of using the middleware due to an issue with accessing the database in the middleware.

Change Form

Fill this up (NA if not available). If a certain criteria is not met, can you please give a reason.

  • The pull request title has an issue number
  • The change works by "Smoke testing" or quick testing
  • The change has tests
  • The change has documentation

Other Information

  • Will look at writing automated tests but this can be merged in prior to that.
  • Added a button in the profile popover to set current user as admin. (Only shows up on dev).

@justinliangg justinliangg requested a review from dct0 February 18, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants