Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 198 repair attempt full screen modal #232

Open
wants to merge 31 commits into
base: main
Choose a base branch
from

Conversation

AarifLamat
Copy link
Collaborator

Change Summary

[Briefly summarise the changes that you made. Just high-level stuff]

Change Form

Fill this up (NA if not available). If a certain criteria is not met, can you please give a reason.

  • The pull request title has an issue number
  • The change works by "Smoke testing" or quick testing
  • The change has tests
  • The change has documentation

Other Information

[Is there anything in particular in the review that I should be aware of?]

…orm to components, adjusted names to not be conflicting
…into issue-198-Repair_attempt_full-screen_modal
…into issue-198-Repair_attempt_full-screen_modal
…into issue-198-Repair_attempt_full-screen_modal
…into issue-198-Repair_attempt_full-screen_modal
Copy link
Collaborator

@justinliangg justinliangg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

For mobile devices, could you make the modal take the entire screen instead of still being a modal.

Example:
Screenshot 2024-02-25 at 9 16 07 am

src/components/FormFields/field-text-area.tsx Outdated Show resolved Hide resolved
src/components/FormFields/field-radio.tsx Outdated Show resolved Hide resolved
src/components/FormFields/field-input.tsx Outdated Show resolved Hide resolved
@AarifLamat
Copy link
Collaborator Author

AarifLamat commented Jun 13, 2024

Nice work!

For mobile devices, could you make the modal take the entire screen instead of still being a modal.

Example: Screenshot 2024-02-25 at 9 16 07 am

It's still a modal but it takes about the full width of the screen, is that good or should it be a separate page on mobile view? The modal uses headlessui's dialog component and it seems that cant take up the whole screen.
@dct0 ?
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants