Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 243 refactor form components and their corresponding forms #245

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

stamle
Copy link
Collaborator

@stamle stamle commented Mar 14, 2024

Change Summary

Major refactor and updated documentation of the following FormFields components:

  • field-input
  • field-multi-select
  • field-single-select
  • field-text-area
  • field-radio

Moved the aforementioned components to new directory called CommonFields

General styling overhaul of the following Form components:

  • event-form
  • prepopulated-event-form

Change Form

Fill this up (NA if not available). If a certain criteria is not met, can you please give a reason.

  • The pull request title has an issue number
  • The change works by "Smoke testing" or quick testing
  • The change has tests
  • The change has documentation

Other Information

The zod schema updateEventSchema maybe needs to be overhauled, it will let you PATCH events with an empty name. I tried changing up the schema but it resulted in failed API tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant