-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 126 embed donation form stripe api integration #170
Issue 126 embed donation form stripe api integration #170
Conversation
…o issue-126-Embed_Donation_form_-_Stripe_API_integration
…o issue-126-Embed_Donation_form_-_Stripe_API_integration
…o issue-126-Embed_Donation_form_-_Stripe_API_integration
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, just one minor thing before it's ready to be merged into main
Done |
I accidentally made a commit with the secret key (test key), still in the file. Please make sure when deployed to change the api key. Other than that, have confirmed with Temper that it works. Need the put stripe_public_key and stripe_secret_key, in environment variables when deployed on vercel. The exact name must be NEXT_PUBLIC_STRIPE_PUBLISHABLE_KEY After that it should work fine, I've edited the code to account for single/monthly payments, with flexibility to choose different amounts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm - great work!
Change Summary
Finished donation page, but still need apikey to test if the stripe payment is fine, not sure. Pretty sure stripe can integrate paypal on its own so I don't think need a seperate paypal page. But if that's what we prefer that's fine too.
Other than that, everything should be good. Feel free to @ me to change any spacing, images.
Change Form
Fill this up (NA if not available). If a certain criteria is not met, can you please give a reason.
Related issue