Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 126 embed donation form stripe api integration #170

Merged
merged 39 commits into from
Mar 14, 2024

Conversation

Aifert
Copy link
Collaborator

@Aifert Aifert commented Mar 11, 2024

Change Summary

Finished donation page, but still need apikey to test if the stripe payment is fine, not sure. Pretty sure stripe can integrate paypal on its own so I don't think need a seperate paypal page. But if that's what we prefer that's fine too.

Other than that, everything should be good. Feel free to @ me to change any spacing, images.

Change Form

Fill this up (NA if not available). If a certain criteria is not met, can you please give a reason.

  • The pull request title has an issue number
  • The change works by "Smoke testing" or quick testing
  • The change has tests
  • The change has documentation

Related issue

Copy link

vercel bot commented Mar 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
starick ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 13, 2024 3:29pm

Copy link
Member

@cjnbennett cjnbennett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, just one minor thing before it's ready to be merged into main

src/pages/api/checkout_sessions/checkout_session.ts Outdated Show resolved Hide resolved
@Aifert
Copy link
Collaborator Author

Aifert commented Mar 12, 2024

Great job, just one minor thing before it's ready to be merged into main

Done

@Aifert
Copy link
Collaborator Author

Aifert commented Mar 12, 2024

I accidentally made a commit with the secret key (test key), still in the file. Please make sure when deployed to change the api key. Other than that, have confirmed with Temper that it works.

Need the put stripe_public_key and stripe_secret_key, in environment variables when deployed on vercel. The exact name must be

NEXT_PUBLIC_STRIPE_PUBLISHABLE_KEY
STRIPE_SECRET_KEY

After that it should work fine, I've edited the code to account for single/monthly payments, with flexibility to choose different amounts.

Copy link
Collaborator

@latrodexia latrodexia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm - great work!

@cjnbennett cjnbennett self-requested a review March 14, 2024 04:52
@Aifert Aifert merged commit 207dd35 into main Mar 14, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Embed Donation form - Stripe API integration
4 participants