remove it (#1480)

coinbase · Jan 16, 2025 · 16fe772 · 16fe772
1 parent 59a6feb
commit 16fe772
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 5 deletions.
diff --git a/packages/wallet-sdk/src/CoinbaseWalletProvider.test.ts b/packages/wallet-sdk/src/CoinbaseWalletProvider.test.ts
@@ -110,7 +110,7 @@ describe('Ephemeral methods', () => {
   });
 
   it('should pass args to SCWSigner', async () => {
-    const args = { method: 'wallet_sign', params: ['0xdeadbeef'] };
+    const args = { method: 'wallet_sendCalls', params: ['0xdeadbeef'] };
     expect(provider['signer']).toBeNull();
     await provider.request(args);
     expect(mockHandshake).toHaveBeenCalledWith({ method: 'handshake' });

diff --git a/packages/wallet-sdk/src/CoinbaseWalletProvider.ts b/packages/wallet-sdk/src/CoinbaseWalletProvider.ts
@@ -54,8 +54,7 @@ export class CoinbaseWalletProvider extends ProviderEventEmitter implements Prov
             storeSignerType(signerType);
             break;
           }
-          case 'wallet_sendCalls':
-          case 'wallet_sign': {
+          case 'wallet_sendCalls': {
             const ephemeralSigner = this.initSigner('scw');
             await ephemeralSigner.handshake({ method: 'handshake' }); // exchange session keys
             const result = await ephemeralSigner.request(args); // send diffie-hellman encrypted request

diff --git a/packages/wallet-sdk/src/sign/scw/SCWSigner.test.ts b/packages/wallet-sdk/src/sign/scw/SCWSigner.test.ts
@@ -167,7 +167,7 @@ describe('SCWSigner', () => {
   });
 
   describe('request - using ephemeral SCWSigner', () => {
-    it.each(['wallet_sign', 'wallet_sendCalls'])(
+    it.each(['wallet_sendCalls'])(
       'should perform a successful request after handshake',
       async (method) => {
         const mockRequest: RequestArguments = { method };

diff --git a/packages/wallet-sdk/src/sign/scw/SCWSigner.ts b/packages/wallet-sdk/src/sign/scw/SCWSigner.ts
@@ -99,7 +99,6 @@ export class SCWSigner implements Signer {
     if (this.accounts.length === 0) {
       switch (request.method) {
         case 'wallet_sendCalls':
-        case 'wallet_sign':
           return this.sendRequestToPopup(request);
         default:
           throw standardErrors.provider.unauthorized();