Set popup name to unique string (#1474)

* set unique window name * update tests * move popup naming * lint
coinbase · Jan 13, 2025 · 3cd583e · 3cd583e
1 parent 88773cb
commit 3cd583e
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/packages/wallet-sdk/src/util/web.test.ts b/packages/wallet-sdk/src/util/web.test.ts
@@ -37,7 +37,7 @@ describe('PopupManager', () => {
     expect(window.open).toHaveBeenNthCalledWith(
       1,
       url,
-      'Smart Wallet',
+      expect.stringContaining('wallet_'),
       'width=420, height=540, left=302, top=114'
     );
     expect(popup.focus).toHaveBeenCalledTimes(1);

diff --git a/packages/wallet-sdk/src/util/web.ts b/packages/wallet-sdk/src/util/web.ts
@@ -10,12 +10,12 @@ const POPUP_HEIGHT = 540;
 export function openPopup(url: URL): Window {
   const left = (window.innerWidth - POPUP_WIDTH) / 2 + window.screenX;
   const top = (window.innerHeight - POPUP_HEIGHT) / 2 + window.screenY;
-
   appendAppInfoQueryParams(url);
 
+  const popupId = `wallet_${crypto.randomUUID()}`;
   const popup = window.open(
     url,
-    'Smart Wallet',
+    popupId,
     `width=${POPUP_WIDTH}, height=${POPUP_HEIGHT}, left=${left}, top=${top}`
   );