update tests

coinbase · Jan 8, 2025 · 4759b97 · 4759b97
1 parent a01ee7f
commit 4759b97
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/packages/wallet-sdk/src/core/communicator/Communicator.test.ts b/packages/wallet-sdk/src/core/communicator/Communicator.test.ts
@@ -161,7 +161,10 @@ describe('Communicator', () => {
 
       const popup = await communicator.waitForPopupLoaded();
 
-      expect(openPopup).toHaveBeenCalledWith(new URL(CB_KEYS_URL));
+      expect(openPopup).toHaveBeenCalledWith(
+        new URL(CB_KEYS_URL),
+        expect.stringContaining('wallet_')
+      );
       expect(mockPopup.postMessage).toHaveBeenNthCalledWith(
         1,
         {

diff --git a/packages/wallet-sdk/src/util/web.test.ts b/packages/wallet-sdk/src/util/web.test.ts
@@ -10,6 +10,8 @@ vi.mock('./checkCrossOriginOpenerPolicy');
 
 const mockOrigin = 'http://localhost';
 
+const mockId = 'wallet_123';
+
 describe('PopupManager', () => {
   beforeAll(() => {
     global.window = Object.create(window);
@@ -32,12 +34,12 @@ describe('PopupManager', () => {
     const url = new URL('https://example.com');
     (window.open as Mock).mockReturnValue({ focus: vi.fn() });
 
-    const popup = openPopup(url);
+    const popup = openPopup(url, mockId);
 
     expect(window.open).toHaveBeenNthCalledWith(
       1,
       url,
-      'Smart Wallet',
+      mockId,
       'width=420, height=540, left=302, top=114'
     );
     expect(popup.focus).toHaveBeenCalledTimes(1);
@@ -51,7 +53,7 @@ describe('PopupManager', () => {
   it('should throw an error if popup fails to open', () => {
     (window.open as Mock).mockReturnValue(null);
 
-    expect(() => openPopup(new URL('https://example.com'))).toThrow(
+    expect(() => openPopup(new URL('https://example.com'), mockId)).toThrow(
       standardErrors.rpc.internal('Pop up window failed to open')
     );
   });