initialize SCWStateManager with dapp chainIds (#1134)

* initialize SCWStateManager with dapp chainIds * test
coinbase · Mar 18, 2024 · baa39e6 · baa39e6
1 parent e71a004
commit baa39e6
Show file tree

Hide file tree

Showing 3 changed files with 34 additions and 2 deletions.
diff --git a/packages/wallet-sdk/src/sign/scw/SCWSigner.ts b/packages/wallet-sdk/src/sign/scw/SCWSigner.ts
@@ -39,6 +39,7 @@ export class SCWSigner implements Signer {
     this.puc = options.puc;
     this.keyManager = new SCWKeyManager();
     this.stateManager = new SCWStateManager({
+      appChainIds: this.appChainIds,
       updateListener: {
         onAccountsUpdate: (...args) => options.updateListener.onAccountsUpdate(this, ...args),
         onChainUpdate: (...args) => options.updateListener.onChainUpdate(this, ...args),

diff --git a/packages/wallet-sdk/src/sign/scw/SCWStateManager.test.ts b/packages/wallet-sdk/src/sign/scw/SCWStateManager.test.ts
@@ -11,6 +11,7 @@ describe('SCWStateManager', () => {
 
   beforeEach(() => {
     stateManager = new SCWStateManager({
+      appChainIds: [DEFAULT_CHAIN.id],
       updateListener: {
         onAccountsUpdate: jest.fn(),
         onChainUpdate: jest.fn(),
@@ -22,6 +23,35 @@ describe('SCWStateManager', () => {
     stateManager.clear();
   });
 
+  describe('fallback to appChainIds[0]', () => {
+    const appChainIds = [10];
+
+    let stateManager: SCWStateManager;
+    beforeEach(() => {
+      stateManager = new SCWStateManager({
+        appChainIds,
+        updateListener: {
+          onAccountsUpdate: jest.fn(),
+          onChainUpdate: jest.fn(),
+        },
+      });
+    });
+    it('should use the first chain id from appChainIds as the active chain', () => {
+      expect(stateManager.activeChain.id).toBe(appChainIds[0]);
+    });
+
+    it('should use the first chain id from appChainIds as the active chain when appChainIds is empty', () => {
+      stateManager = new SCWStateManager({
+        appChainIds: [],
+        updateListener: {
+          onAccountsUpdate: jest.fn(),
+          onChainUpdate: jest.fn(),
+        },
+      });
+      expect(stateManager.activeChain.id).toBe(1);
+    });
+  });
+
   describe('switchChain', () => {
     beforeEach(() => {
       stateManager.updateAvailableChains(AVAILABLE_CHAINS);
@@ -64,6 +94,7 @@ describe('SCWStateManager', () => {
 
     beforeEach(() => {
       stateManager = new SCWStateManager({
+        appChainIds: [1],
         updateListener: {
           onAccountsUpdate: jest.fn(),
           onChainUpdate: chainUpdatedListener,

diff --git a/packages/wallet-sdk/src/sign/scw/SCWStateManager.ts b/packages/wallet-sdk/src/sign/scw/SCWStateManager.ts
@@ -20,7 +20,7 @@ export class SCWStateManager {
     return this._activeChain;
   }
 
-  constructor(options: { updateListener: StateUpdateListener }) {
+  constructor(options: { appChainIds: number[]; updateListener: StateUpdateListener }) {
     this.updateListener = options.updateListener;
 
     this.availableChains = this.loadItemFromStorage(AVAILABLE_CHAINS_STORAGE_KEY);
@@ -41,7 +41,7 @@ export class SCWStateManager {
     }
 
     this._accounts = accounts || [];
-    this._activeChain = chain || { id: 1 };
+    this._activeChain = chain || { id: options.appChainIds?.[0] ?? 1 };
   }
 
   updateAccounts(accounts: AddressString[]) {