Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#trivial Revert "update testapp to 4.0.1 (#1300)" #1302

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/testapp/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"@chakra-ui/react": "^2.8.0",
"@coinbase/wallet-sdk-3.7.2": "npm:@coinbase/[email protected]",
"@coinbase/wallet-sdk-3.9.3": "npm:@coinbase/[email protected]",
"@coinbase/wallet-sdk-4.0.1": "npm:@coinbase/[email protected].1",
"@coinbase/wallet-sdk-4.0.0": "npm:@coinbase/[email protected].0",
"@emotion/react": "^11.11.1",
"@emotion/styled": "^11.11.0",
"@metamask/eth-sig-util": "^7.0.0",
Expand Down
2 changes: 1 addition & 1 deletion apps/testapp/src/components/Layout.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ export function Layout({ children }: LayoutProps) {
))}
</MenuList>
</Menu>
{sdkVersion === '4.0.1' && (
{sdkVersion === '4.0.0' && (
<>
<Menu>
<MenuButton as={Button} rightIcon={<ChevronDownIcon />}>
Expand Down
10 changes: 5 additions & 5 deletions apps/testapp/src/context/CBWSDKReactContextProvider.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { CoinbaseWalletSDK as CoinbaseWalletSDK372 } from '@coinbase/wallet-sdk-3.7.2';
import { CoinbaseWalletSDK as CoinbaseWalletSDK393 } from '@coinbase/wallet-sdk-3.9.3';
import { CoinbaseWalletSDK as CoinbaseWalletSDK401 } from '@coinbase/wallet-sdk-4.0.1';
import { CoinbaseWalletSDK as CoinbaseWalletSDK400 } from '@coinbase/wallet-sdk-4.0.0';
import React, { useEffect, useMemo } from 'react';

type CBWSDKProviderProps = {
Expand All @@ -10,7 +10,7 @@ type CBWSDKProviderProps = {
const CBWSDKReactContext = React.createContext(null);

const SELECTED_SDK_KEY = 'selected_sdk_version';
export const sdkVersions = ['4.0.1', '3.9.3', '3.7.2'] as const;
export const sdkVersions = ['4.0.0', '3.9.3', '3.7.2'] as const;
export type SDKVersionType = (typeof sdkVersions)[number];

const SELECTED_SCW_URL_KEY = 'scw_url';
Expand Down Expand Up @@ -73,8 +73,8 @@ export function CBWSDKReactContextProvider({ children }: CBWSDKProviderProps) {
useEffect(() => {
let cbwsdk;
let preference;
if (version === '4.0.1') {
cbwsdk = new CoinbaseWalletSDK401({
if (version === '4.0.0') {
cbwsdk = new CoinbaseWalletSDK400({
appName: 'SDK Playground',
appChainIds: [84532, 8452],
});
Expand All @@ -99,7 +99,7 @@ export function CBWSDKReactContextProvider({ children }: CBWSDKProviderProps) {
}, [version, option]);

useEffect(() => {
if (version === '4.0.1') {
if (version === '4.0.0') {
if (scwUrl) window.setPopupUrl?.(scwUrl);
}
}, [version, scwUrl, sdk]);
Expand Down
58 changes: 36 additions & 22 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -2825,7 +2825,42 @@ __metadata:
languageName: node
linkType: hard

"@coinbase/wallet-sdk-4.0.1@npm:@coinbase/[email protected], @coinbase/wallet-sdk@workspace:packages/wallet-sdk":
"@coinbase/wallet-sdk-4.0.0@npm:@coinbase/[email protected]":
version: 4.0.0
resolution: "@coinbase/wallet-sdk@npm:4.0.0"
dependencies:
buffer: ^6.0.3
clsx: ^1.2.1
eventemitter3: ^5.0.1
keccak: ^3.0.3
preact: ^10.16.0
sha.js: ^2.4.11
checksum: f9101233cd4529daae235eb01fcd10fe3c9ab075b3171beacb755ff475be7a9e33957fb4ffedbdd34092c3045ddcbf6fda181a5adfd531307a4cc8937861ef38
languageName: node
linkType: hard

"@coinbase/wallet-sdk-testapp@workspace:apps/testapp":
version: 0.0.0-use.local
resolution: "@coinbase/wallet-sdk-testapp@workspace:apps/testapp"
dependencies:
"@chakra-ui/icons": ^2.1.1
"@chakra-ui/react": ^2.8.0
"@coinbase/wallet-sdk-3.7.2": "npm:@coinbase/[email protected]"
"@coinbase/wallet-sdk-3.9.3": "npm:@coinbase/[email protected]"
"@coinbase/wallet-sdk-4.0.0": "npm:@coinbase/[email protected]"
"@emotion/react": ^11.11.1
"@emotion/styled": ^11.11.0
"@metamask/eth-sig-util": ^7.0.0
"@types/react": 18.2.15
framer-motion: ^10.13.1
next: ^13.5.0
react: ^18.2.0
react-dom: ^18.2.0
react-hook-form: ^7.45.2
languageName: unknown
linkType: soft

"@coinbase/wallet-sdk@workspace:packages/wallet-sdk":
version: 0.0.0-use.local
resolution: "@coinbase/wallet-sdk@workspace:packages/wallet-sdk"
dependencies:
Expand Down Expand Up @@ -2861,27 +2896,6 @@ __metadata:
languageName: unknown
linkType: soft

"@coinbase/wallet-sdk-testapp@workspace:apps/testapp":
version: 0.0.0-use.local
resolution: "@coinbase/wallet-sdk-testapp@workspace:apps/testapp"
dependencies:
"@chakra-ui/icons": ^2.1.1
"@chakra-ui/react": ^2.8.0
"@coinbase/wallet-sdk-3.7.2": "npm:@coinbase/[email protected]"
"@coinbase/wallet-sdk-3.9.3": "npm:@coinbase/[email protected]"
"@coinbase/wallet-sdk-4.0.1": "npm:@coinbase/[email protected]"
"@emotion/react": ^11.11.1
"@emotion/styled": ^11.11.0
"@metamask/eth-sig-util": ^7.0.0
"@types/react": 18.2.15
framer-motion: ^10.13.1
next: ^13.5.0
react: ^18.2.0
react-dom: ^18.2.0
react-hook-form: ^7.45.2
languageName: unknown
linkType: soft

"@cspotcode/source-map-support@npm:^0.8.0":
version: 0.8.1
resolution: "@cspotcode/source-map-support@npm:0.8.1"
Expand Down
Loading