Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: invalid params passed to personal_sign Example Message action #1471

Conversation

montycheese
Copy link
Contributor

@montycheese montycheese commented Jan 2, 2025

Summary

  • data was being passed into verify instead of dataToSubmit which is the mapped variable to translates ADDR_TO_FILL to the connected address.

How did you test your changes?

Tested manually -- the "example message" action under the personal_sign section works without errors now after the fix
Screenshot 2025-01-02 at 9 12 59 AM

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Jan 2, 2025

✅ Heimdall Review Status

Requirement Status More Info
Reviews 2/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@cb-heimdall
Copy link
Collaborator

Review Error for eric-ships @ 2025-01-07 16:11:10 UTC
User failed mfa authentication, see go/mfa-help

@montycheese montycheese merged commit 7ca032d into coinbase:master Jan 8, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants