Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TRIVIAL - rename to handshake #1479

Merged
merged 1 commit into from
Jan 16, 2025
Merged

TRIVIAL - rename to handshake #1479

merged 1 commit into from
Jan 16, 2025

Conversation

fan-zhang-sv
Copy link
Contributor

@fan-zhang-sv fan-zhang-sv commented Jan 16, 2025 •
edited
Loading

Summary

just renaming an internal RPC method

How did you test your changes?

Screen.Recording.2025-01-16.at.3.22.22.PM.mov

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Jan 16, 2025 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@fan-zhang-sv fan-zhang-sv merged commit 59a6feb into master Jan 16, 2025
8 checks passed
@fan-zhang-sv fan-zhang-sv deleted the felix/rename-handshake branch January 16, 2025 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cb-jake cb-jake cb-jake approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fan-zhang-sv @cb-heimdall @cb-jake