Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typos #1481

Merged
merged 1 commit into from
Jan 20, 2025
Merged

fix typos #1481

merged 1 commit into from
Jan 20, 2025

Conversation

crStiv
Copy link
Contributor

@crStiv crStiv commented Jan 18, 2025

No description provided.

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Jan 18, 2025 •
edited
Loading

✅ Heimdall Review Status

Requirement Status More Info
Reviews ✅ 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

eric-ships
eric-ships approved these changes Jan 18, 2025
View reviewed changes
Copy link
Contributor

@eric-ships eric-ships left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏🏼

@crStiv
Copy link
Contributor Author

crStiv commented Jan 20, 2025

@eric-ships if everything if fine, then merge?

@eric-ships eric-ships merged commit 3f48bcc into coinbase:master Jan 20, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-ships eric-ships eric-ships approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crStiv @cb-heimdall @eric-ships