Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for sub account and the new addAddress RPC #1490

Closed
wants to merge 5 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -41,3 +41,5 @@ examples/**/yarn.lock

# next.js
.next

tsconfig.tsbuildinfo
2 changes: 1 addition & 1 deletion examples/testapp/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"react": "^18.2.0",
"react-dom": "^18.2.0",
"react-hook-form": "7.45.2",
"viem": "2.21.1"
"viem": "^2.22.16"
},
"devDependencies": {
"@types/react": "18.2.15",
Expand Down
10 changes: 5 additions & 5 deletions examples/testapp/src/context/CBWSDKReactContextProvider.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -161,11 +161,11 @@ export function CBWSDKReactContextProvider({ children }: CBWSDKProviderProps) {
setProvider(cbwprovider);

return () => {
cbwprovider.removeListener('connect', handleConnect);
cbwprovider.removeListener('disconnect', handleDisconnect);
cbwprovider.removeListener('accountsChanged', handleAccountsChanged);
cbwprovider.removeListener('chainChanged', handleChainChanged);
cbwprovider.removeListener('message', handleMessage);
cbwprovider.off('connect', handleConnect);
cbwprovider.off('disconnect', handleDisconnect);
cbwprovider.off('accountsChanged', handleAccountsChanged);
cbwprovider.off('chainChanged', handleChainChanged);
cbwprovider.off('message', handleMessage);
};
}, [version, option, config]);

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
import { Box, Button } from '@chakra-ui/react';
import { createCoinbaseWalletSDK } from '@coinbase/wallet-sdk';
import React, { useCallback, useState } from 'react';

export function AddAddressButton({ sdk }: { sdk: ReturnType<typeof createCoinbaseWalletSDK> }) {
const [subAccount, setSubAccount] = useState<string>();

const handleAddAddress = useCallback(async () => {
if (!sdk) {
return;
}
const provider = sdk.getProvider();
const response = (await provider.request({
method: 'wallet_addAddress',
params: [
{
chainId: 84532,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idea being this address is limited to one chain, correct?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should check this with partners

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes the idea was each account is per chain and we wont sync across chains

},
],
})) as { address: string };

console.info('customlogs: response', response);

setSubAccount(response.address);
}, [sdk]);

return (
<>
<Button w="full" onClick={handleAddAddress}>
Add Address
</Button>
{subAccount && (
<Box
as="pre"
w="full"
p={2}
bg="gray.900"
borderRadius="md"
border="1px solid"
borderColor="gray.700"
>
{JSON.stringify(subAccount, null, 2)}
</Box>
)}
</>
);
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
import { Box, Button } from '@chakra-ui/react';
import { createCoinbaseWalletSDK } from '@coinbase/wallet-sdk';
import React, { useCallback, useState } from 'react';

export function ConnectButton({ sdk }: { sdk: ReturnType<typeof createCoinbaseWalletSDK> }) {
const [state, setState] = useState<string[]>();
const handleConnect = useCallback(async () => {
if (!sdk) {
return;
}

const provider = sdk.getProvider();
const response = await provider.request({
method: 'eth_requestAccounts',
});

console.info('customlogs: response', response);
setState(response as string[]);
}, [sdk]);

return (
<>
<Button w="full" onClick={handleConnect}>
Connect
</Button>
{state && (
<Box
as="pre"
w="full"
p={2}
bg="gray.900"
borderRadius="md"
border="1px solid"
borderColor="gray.700"
>
{JSON.stringify(state, null, 2)}
</Box>
)}
</>
);
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
import { Box, Button } from '@chakra-ui/react';
import { createCoinbaseWalletSDK } from '@coinbase/wallet-sdk';
import React, { useCallback, useState } from 'react';
import { toHex } from 'viem';

export function PersonalSignButton({ sdk }: { sdk: ReturnType<typeof createCoinbaseWalletSDK> }) {
const [state, setState] = useState<string>();
const handlePersonalSign = useCallback(async () => {
if (!sdk) {
return;
}

const provider = sdk.getProvider();
try {
const response = await provider.request({
method: 'personal_sign',
params: [toHex('Hello, world!')],
});
console.info('customlogs: response', response);
setState(response as string);
} catch (e) {
console.error('customlogs: error', e);
}
}, [sdk]);

return (
<>
<Button w="full" onClick={handlePersonalSign}>
Personal Sign
</Button>
{state && (
<Box
as="pre"
w="full"
p={2}
bg="gray.900"
borderRadius="md"
border="1px solid"
borderColor="gray.700"
overflow="auto"
whiteSpace="pre-wrap"
>
{JSON.stringify(state, null, 2)}
</Box>
)}
</>
);
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,59 @@
import { Box, Button } from '@chakra-ui/react';
import { createCoinbaseWalletSDK } from '@coinbase/wallet-sdk';
import React, { useCallback, useState } from 'react';
import { baseSepolia } from 'viem/chains';

export function SendCallsButton({ sdk }: { sdk: ReturnType<typeof createCoinbaseWalletSDK> }) {
const [state, setState] = useState<string>();
const handleSendCalls = useCallback(async () => {
if (!sdk) {
return;
}

const provider = sdk.getProvider();
try {
const response = await provider.request({
method: 'wallet_sendCalls',
params: [
{
chainId: baseSepolia.id,
calls: [],
version: '1',
// capabilities: {
// paymasterService: {
// url: '',
// },
// },
},
],
});
console.info('customlogs: response', response);
setState(response as string);
} catch (e) {
console.error('customlogs: error', e);
}
}, [sdk]);

return (
<>
<Button w="full" onClick={handleSendCalls}>
Send Calls
</Button>
{state && (
<Box
as="pre"
w="full"
p={2}
bg="gray.900"
borderRadius="md"
border="1px solid"
borderColor="gray.700"
overflow="auto"
whiteSpace="pre-wrap"
>
{JSON.stringify(state, null, 2)}
</Box>
)}
</>
);
}
44 changes: 44 additions & 0 deletions examples/testapp/src/pages/sub-accounts/index.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
import { Container, VStack } from '@chakra-ui/react';
import { createCoinbaseWalletSDK } from '@coinbase/wallet-sdk';
import React, { useEffect, useState } from 'react';

import { AddAddressButton } from './components/AddAddressButton';
import { ConnectButton } from './components/ConnectButton';
import { PersonalSignButton } from './components/PersonalSignButton';
import { SendCallsButton } from './components/SendCallsButton';

export default function SubAccounts() {
const [sdk, setSDK] = useState<ReturnType<typeof createCoinbaseWalletSDK>>();

useEffect(() => {
const sdk = createCoinbaseWalletSDK({
appName: 'CryptoPlayground',
preference: {
keysUrl: 'http://localhost:3005/connect',
options: 'smartWalletOnly',
},
});

if (!sdk) {
return;
}

setSDK(sdk);
const provider = sdk.getProvider();

provider.on('accountsChanged', (accounts) => {
console.info('customlogs: accountsChanged', accounts);
});
}, []);

return (
<Container mb={16}>
<VStack w="full" spacing={4}>
<ConnectButton sdk={sdk} />
<AddAddressButton sdk={sdk} />
<PersonalSignButton sdk={sdk} />
<SendCallsButton sdk={sdk} />
</VStack>
</Container>
);
}
8 changes: 7 additions & 1 deletion packages/wallet-sdk/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,12 @@
"@noble/hashes": "^1.4.0",
"clsx": "^1.2.1",
"eventemitter3": "^5.0.1",
"preact": "^10.24.2"
"idb-keyval": "^6.2.1",
"ox": "^0.6.5",
"preact": "^10.24.2",
"viem": "^2.22.16",
"webauthn-p256": "^0.0.10",
"zustand": "^5.0.3"
},
"devDependencies": {
"@size-limit/preset-big-lib": "^11.1.6",
Expand All @@ -48,6 +53,7 @@
"eslint-plugin-prettier": "^5.0.0",
"eslint-plugin-simple-import-sort": "^10.0.0",
"eslint-plugin-unused-imports": "^3.0.0",
"fake-indexeddb": "^6.0.0",
"glob": "^11.0.0",
"jest-websocket-mock": "^2.4.0",
"jsdom": "^25.0.1",
Expand Down
7 changes: 7 additions & 0 deletions packages/wallet-sdk/src/core/message/RPCResponse.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
import { SerializedEthereumRpcError } from '../error/utils.js';

type NativeCurrency = {
symbol: string;
name: string;
decimal: number;
};

export type RPCResponse = {
result:
| {
Expand All @@ -11,6 +17,7 @@ export type RPCResponse = {
data?: {
// optional data
chains?: { [key: number]: string };
nativeCurrencies?: { [key: number]: NativeCurrency };
capabilities?: Record<`0x${string}`, Record<string, unknown>>;
};
};
27 changes: 27 additions & 0 deletions packages/wallet-sdk/src/core/storage/createIdbStorage.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
import { createIdbStorage } from './createIdbStorage.js';

describe('createIdbStorage', () => {
it('should create an indexedDB storage', () => {
const storage = createIdbStorage('test', 'test');
expect(storage).toBeDefined();
});

it('getItem', async () => {
const storage = createIdbStorage('test', 'test');
await storage.setItem('foo', 'bar');
expect(await storage.getItem('foo')).toEqual('bar');
});

it('setItem', async () => {
const storage = createIdbStorage('test', 'test');
await storage.setItem('foo', 'bar');
expect(await storage.getItem('foo')).toEqual('bar');
});

it('removeItem', async () => {
const storage = createIdbStorage('test', 'test');
await storage.setItem('foo', 'bar');
await storage.removeItem('foo');
expect(await storage.getItem('foo')).toEqual(null);
});
});
26 changes: 26 additions & 0 deletions packages/wallet-sdk/src/core/storage/createIdbStorage.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
import { createStore, del, get, set } from 'idb-keyval';

export type IdbStorage = {
getItem: <T>(key: string) => Promise<T | null>;
removeItem: (key: string) => Promise<void>;
setItem: (key: string, value: unknown) => Promise<void>;
};

export function createIdbStorage(scope: string, name: string): IdbStorage {
const store = typeof indexedDB !== 'undefined' ? createStore(scope, name) : undefined;
return {
getItem: async (key: string) => {
const value = await get(key, store);
if (!value) {
return null;
}
return value;
},
removeItem: async (key: string) => {
return del(key, store);
},
setItem: async (key: string, value: unknown) => {
return set(key, value, store);
},
};
}
Loading
Loading